elgatito / plugin.video.elementum

Elementum add-on for Kodi. Development of this addon has been stopped!
http://elementum.surge.sh
MIT License
484 stars 159 forks source link

[Request] Review Fanart arts collections. #637

Closed matke-84 closed 3 years ago

matke-84 commented 3 years ago

As the title says. When I use the default fanart I don't get a clearlogo on any of the skins. When I turn on fanart.tv I get everything but everything is very slow and to be honest I get weird backgrounds, instead of backgrounds it is often clearart so it looks weird, then I get weird clearlogos ... Is there a possibility to get complete support with default fanart for posters and images (clearlogos, cleararts...). I know there is no more support for the element but I would be very grateful if you could fix this. Thanks in advance.

elgatito commented 3 years ago

@matke-84 If you think there are arts on TMDB, which you don't see through Elementum - provide exact TMDB item, so it can be inspected.

matke-84 commented 3 years ago

Sorry maybe I wasn't clear. With the default element settings I don't get a clearlogs. default settings no clearlogos When I turn on use fanart.tv I get everything but with this setting it's slower loading. Secondly, I get for a lot of movies instead of a background cleaart and it looks very weird then. fanart tv with clearlogo This all happens with all skins that support fanart clearlogos. I also contacted some skin creators and people from fanart.tv and they all told me that the problem is with the elementum, supposedly something needs to be sorted out to get full support, elementum api problem or something like that. Sorry for the longer post but I don't know how else to explain.

elgatito commented 3 years ago

@matke-84 As I've said before, please, provide an item which has arts on TMDB website, and you don't see that arts in Kodi/Elementum.

https://www.themoviedb.org/

matke-84 commented 3 years ago

Sorry but we don't seem to understand each other. There are no clearlogos (movies title logos) on tmdb. Not a problem with posters and backgrounds. Please look carefully at the pictures. Clearlogos only exist on fanart.tv as i know. clearlogo title It needs to set to pull posters and wallpapers from tmdb for movies and tvdb for tv shows and everything else from fanart.tv. This was done by some other similar addons. Or at least if you can set that when you turn on use fanart.tv option pulls the background properly and not clearart. It looks ugly like this. wrong background I got this in response when I asked a question on fanart.tv about incorrect background views. Screenshot_20201111-162452 It would be really nice if this could be sorted out. Many would be grateful to you for this. Thanks in advance. If you need any help, I'm here.

elgatito commented 3 years ago

@matke-84

Sorry but we don't seem to understand each other.

You are right. I don't understand what you want. You say there are not clear arts, then you say it is wrong, then you say it is on fanart, but you don't like it, then you say it should be fanart. I do not understand.

elgatito commented 3 years ago

That is why I asked two times to provide a sample of an item on TMDB, where you show that "this art should there and there", so that it is clear what should be where.

matke-84 commented 3 years ago

Sorry but I really don't know how else to explain. You don't have a clearlogo on tmdb, so I don't know what to show you. But I can show you on fanart.tv. For example on the movie the godfather: I want clearlogos on every movie: Screenshot_20201111-171431 Instead of this clearart: Screenshot_20201111-171458 I want it to be the background Screenshot_20201111-171534 This is how it looks like when the option "use fanart.tv for poster/images" is not turned on. This is default setings in elementum. no clearlogo As you can see there are posters and backgrounds but no clearlog. This is how it looks like when the mentioned option is turned on. clearlogo and back As you can see a clearlogo has appeared but it is clearart instead of the background. All of this happens in both tv shows and movies. I can't do better than this. :-)

elgatito commented 3 years ago

@matke-84 but why don't you enable use of fanart.tv in Elementum settings? It does not work as expected?

matke-84 commented 3 years ago

I use it, but it loads images much slower, but I can handle that. But as you stated, it doesn't work properly, more precisely, it shows posters properly, but the backgrounds for a lot of movies are not good (the Godfather, LOTR, Dark knight, Harry Potter, Back to the future......). It displays cleararts instead of backgrounds. I sent it to you in previous posts. You need to fix that. And the answer from the people from fanart.tv that I posted says the same thing. Screenshot_20201111-162452

elgatito commented 3 years ago

@matke-84 Here and below you can see which fields are used for each art type for Kodi: https://github.com/elgatito/elementum/blob/master/fanart/fanart.go#L270

I don't see where we can get clearlogo for movies. For shows/seasons/episodes we should currently use ClearArt and ClearLogo.

matke-84 commented 3 years ago

Sorry, I'm not the best at programming kodi addon. Clearlogos and cleararts for movies and tv shows we can use from https://fanart.tv/. Can we use tmdb-tvdb id in combination with fanart.tv id?

elgatito commented 3 years ago

@matke-84 I have posted the link just to verify what data from fanart is used for what art in Kodi.

Example for movie:

ClearArt:  HDMovieClearArt
ClearLogo: HDMovieLogo or MovieLogo

I do not see ClearLogo data from Fanart, is it there? Can you show any Movie and TVShow on Fanart, that has arts, that you want to see in Elementum?

matke-84 commented 3 years ago

For example The Dark knight. https://fanart.tv/movie/155/the-dark-knight/ Clearlogo (also clearart) is no longer used for newer titles, now there is hdclearlogo (hdclearart) . But you can add in code for any case if not exist hdclearlogo to use clearlogo. Screenshot_20201111-213736 Posters are not a problem, so far they have been ok. Screenshot_20201111-214227 Now, it is important to fix this, so that the movie background be a background, not clearart, it has a different role. Screenshot_20201111-214734 Purely as additional information, there is also a cdart and banners used by some skins, so if you want you can insert it into the code. Screenshot_20201111-215214 Screenshot_20201111-220014 If there's anything I can do to help you, test or whatever, I'm here.

matke-84 commented 3 years ago

Here are the links if it's easier: HDCLEARLOGO(hdmovielogo)-https://fanart.tv/fanart/movies/155/hdmovielogo/the-dark-knight-507b2081e02dd.png POSTER(movieposter)-https://fanart.tv/fanart/movies/155/movieposter/the-dark-knight-551465d577af5.jpg BACKGROUND(moviebackground)-https://fanart.tv/fanart/movies/155/moviebackground/the-dark-knight-58fa275637ae0.jpg If you need the rest (HDCLEARLOGO,CDART,BANNER,MOVIE THUMBS...) I can leave links for that too.

elgatito commented 3 years ago

@matke-84 there is no "ClearLogo" in Fanart for movies. There is only "ClearArt". Kodi has fields for both ClearLogo and ClearArt. Currently we pass ClearArt as it is. For ClearLogo we pass HDMovieLogo.

matke-84 commented 3 years ago

Ok, I figured it out too in the end as you can see from my previous post. :-) Is there anything that can be done to fix these issues from all previous posts?

elgatito commented 3 years ago

@matke-84 I have no idea what you want to fix and don't have time to sort everything. If you say "this field in Kodi Art should be set with this field from Fanart" - I can do that. As I said, you can see what fields in Kodi are set from Fanart.

JacopoV commented 3 years ago

@elgatito Hi, i do have a similar issue, and i ve been able to isolate the issue to be related with some recent elemetum updates (at least it seems ). I had to install a 2/3 weeks backup for kodi and i notice far art was loaded correctly, then updated to the last version but they don't show up anymore, even tho the option are checked. If i provide both logs, both pictures and both instrtuctions, you want to me log the bug here or in a new one ? Many thanks

EDIT : i ve collected all pictures, comparisons and logs. It works fine on 0.1.59 but no longer works on 0.1.62. I've manually updated the addons from my backup with 0.1.59 (burst and movie db scraper and everything was still ok. As soon as i've updated elementum, the issue showed up )

elgatito commented 3 years ago

@JacopoV you should be more clear what does not work for you and where. I do not understand what you write about.

JacopoV commented 3 years ago

@elgatito i apologise if i haven't been clear enough. So before opening a ticket i ve looked into if someone else was having the same issue i do have. And this one seems pretty similar, due the fact that has something to do with clearart and clearlogo ( i think). So the issue is : in Elemetum settings i've both "Use default fan art " and " Use fanart.tv for poster/images" on . With these 2 options turned on, in Aura UI, in landscape widgets i get the correct background and the logo overlapping nicely. If i do turn off these 2 settings i mentioned in Elemetum, in the landscape widget the background stays and the logo goes away. In Elementum 0.1.59 it still works like that, so both settings on and i ve no issues at all. In Elementum 0.1.62 , even both settings are turned on, i get only the background and not the logo.

I do have logs, all screen photos etc if you think you have the time to look into, if it's an issue with elementum at all, for both 0.1.59 and 0.1.62. As stated before, this behaviour happens only if i update Elementum. I can stick with 0.1.59 but i like to get the latest updates, especially to solve Trakt issue, for their sake considering they requested changes.

elgatito commented 3 years ago

With these 2 options turned on, in Aura UI, in landscape widgets i get the correct background and the logo overlapping nicely. If i do turn off these 2 settings i mentioned in Elemetum, in the landscape widget the background stays and the logo goes away.

You are talking about logo only? Lists of items or when you start playback of some item? Would be good if you share which movie/show/season/episode you look at, show a screenshot where arts look fine, and screenshot where it is not good.

JacopoV commented 3 years ago

@elgatito yeah just the logo in the UI, before playing. Ok i ll give you everything i got, gimme a bit to format a post so i can make your life easier and be more helpful :)

JacopoV commented 3 years ago

@elgatito So here we are. Both Elementum having "Use default fan art " and " Use fanart.tv for poster/images" turned ON for 0.1.59 and 0.1.62 .

Focus area : look at the widgets in the second row, like True Detective , Money Heist and Dark, which are Trakt in progress list if it does matter.

About updates : once i push back in my Kodi backup, there are 2 addons they wants to be updated : Elementum, Burst for Elementum. Burst is not causing any issue, so due my testing, the issues shows up when i apply the update for Elementum from 0.1.59 to 0.1.62 . Between the tests and debug, i always fully reboot Kodi.

System : Android 9 TV running Kodi 18.9

Elementum 0.1.59 How it looks : 0 1 59

As you can see the logo ( in this case the show title) is displayed on top the background as still image from the episode. LOG for 0.1.59 before updating : https://paste.kodi.tv/datacudozu

Elementum 0.1.62 How it looks : 0 1 62

As you can see the logo that was displayed on top the background as still image from the episode, it's not visible anymore. LOG for 0.1.62 after being updated : http://paste.kodi.tv/binohuvuge

Let me know if i can help you proving more info or running more test. I can easily revert back to my backup before the update. Thanks for your time

elgatito commented 3 years ago

@JacopoV Do you see the same with movies? Upper row is not from Elementum, so other arts are used?

Let's take a look at Dark arts. TMDB: https://www.themoviedb.org/tv/70523-dark/images/backdrops Fanart: https://fanart.tv/series/334824/dark/

Fields, taken by Kodi:

thumb
poster
banner
fanart
clearart
clearlogo
landscape
icon

We need to review where should each item go to. Difference between 0.1.59 and 0.1.62, when using Fanart, is that we don't take usual Logo for ClearLogo arts. https://github.com/elgatito/elementum/commit/7492b22e4f5d2d440f41d093bdc047c05c36290a

JacopoV commented 3 years ago

@elgatito first thanks for the quick look.

Regarding your question (very valid one) it seems to be more spread on TV shows , sometimes on movies if they work in the same way. I thought it was because they were too recent or something like it. The upper row, in TV Show section, is still Trakt. It's the collection in my account.

I made a short video in here to show you more. Maybe you spot something more than i do : https://gofile.io/d/8rLkJY

matke-84 commented 3 years ago

OK. I noticed one more thing. If I turn on the option in elementum to pull data from trakt then neither clearlogo nor clearart appears anymore. I still think something is not right here. For example in tmdb helper it does everything properly with trakt lists. Don't get me wrong, I love so much this addon and I have great respect for you and your work, I'm just trying to make it as good as possible.

elgatito commented 3 years ago

@matke-84 If you enable to use Trakt information, it means Trakt items are not overwritten with TMDB information and images. It will not help with images, at all.

JacopoV commented 3 years ago

@elgatito regarding "my issue" is there something i can do to fix it ? about this change elgatito/elementum@7492b22 ? thanks

JacopoV commented 3 years ago

As workaround I rolled back to Elememtum 0.1.59 for now. Hopefully in the future releases can be fixed, if you have time @elgatito. Thanks for your precious time.

matke-84 commented 3 years ago

@elgatito There is something wrong with the latest version. It has a problem to pull movies or tv show logos especially for tv shows. For example Stranger Things, Flash... It works with version 0.1.61.

elgatito commented 3 years ago

@JacopoV @matke-84 which skins you use on your screenshots?

matke-84 commented 3 years ago

Titan bingie mod, and for movie Superintelligence i got russian logo.

matke-84 commented 3 years ago

And I found something else very interesting. TMDB helper also takes pictures, logos ... from fanart.tv but he doesn't have the problems we wrote about here and somehow everything looks cleaner. Could changing or updating fanart.tv api key be a solution?

elgatito commented 3 years ago

@JacopoV How can I make same view as you have with your skin? I guess it is default Aura skin? How to make big images with clear logos?

JacopoV commented 3 years ago

@elgatito Hey Denis, sorry, I've never received any notifications about this thread till this last tag. Thanks for looking into.

Yeah it's normal Aura. The best way to have the layout showing the issue, is to go to :

Options that are needed to see background + logo ( working in 0.1.59 ) are :

It should be enough. Let me know please if you're able to reproduce it, otherwise i can make a video with a passthru of all the settings i have. Many thanks

elgatito commented 3 years ago

@JacopoV Could finally find the place to see logo over the landscape, thanks.

JacopoV commented 3 years ago

No worries, thanks to you @elgatito. Any idea if could be fixed in a future release? I m still on 0.1.59 because of that.

Cheers

matke-84 commented 3 years ago

@elgatito There is something wrong with the latest version. It has a problem to pull movies or tv show logos especially for tv shows. For example Stranger Things, Flash... It works with version 0.1.61.

@elgatito Is there a chance to fix this problem with the latest version of the elementum?

JacopoV commented 3 years ago

@matke-84 I think we have the same issue. I'm using elementum 0.1.59, but in 0.1.62 a change has been done about it. So we are both affected..

matke-84 commented 3 years ago

@JacopoV It seems to me. All we have to do is wait for @elgatito sort it out.

elgatito commented 3 years ago

@JacopoV @matke-84 Please, try with v0.1.63.

matke-84 commented 3 years ago

@elgatito Omg, you managed to fix the fanarts. I've been telling you about this all time. Now it shows everything much better. There are still some things that tmdb helper shows me and elementum doesn't but I will check it again and let you know. Is there a chance to insert MPAA ratings for movies and tv shows? It would be awesome.

elgatito commented 3 years ago

@matke-84 I have tried to add MPAA where possible to movies/shows. But it's not everywhere there. Please, try with 0.1.64.

matke-84 commented 3 years ago

@elgatito I can't find version 0.1.64.

matke-84 commented 3 years ago

@elgatito My mistake. Found. I'll try.

elgatito commented 3 years ago

@matke-84 It was a delay with release upload. Now finishing just items.

matke-84 commented 3 years ago

@elgatito I don't get an MPAA. Do I need to do something special? I use titan bingie mod skin.

elgatito commented 3 years ago

@matke-84 Try to "Clear TMDB cache", in Elementum settings.

matke-84 commented 3 years ago

@elgatito Nope , I tried everything but nothing. It works in tmdb helper.

elementum vs tmdb helper

matke-84 commented 3 years ago

@elgatito There is also a lack of pictures here. I'm trying to find a solution to the problem today, but I'm not doing well. Elementum does not find an image. In TMDB helper appears. Can you help me where to look.

missing picture

Titan bingie mod skin part of code which I suspect is in charge of this.

`

String.Contains(Control.GetLabel(12345),landscape) yes 20 15 570 350 keep videoInfoColorDiffuse $VAR[View525SeasonOrShowLandscape] `