[Bug] Subtitle error when use elementum search option

matke-84 commented 3 years ago

@elgatito When you enter the element search and select a movie or tv show, after loading the movie when you want to download subtitle throw out the next error: "Error searching for subtitles. Manual search string." This error was reported to me my friend. I checked and the same thing happens to me and few more my friends, with all subtitle addons as with the default elementum.

elgatito commented 3 years ago

@matke-84 log file?

matke-84 commented 3 years ago

@elgatito Sorry, I forgot. https://easyupload.io/s7lpe7 One correction, the default elementum works but the other three don't. You will probably see in the log that I first opened the movie normally (it works) and the second time through the search option (It doesn't work).

elgatito commented 3 years ago

@matke-84 I don't understand this. Built-in subtitles provider uses OSDB and uses original movie/show title to search for subtitles. I don't know if it is possible to change the search query.

matke-84 commented 3 years ago

@elgatito Searching from folders where movies and tv shows are working well, there is no problem with subtitles. But this search is a little strange. I thought it served as a universal search but instead of dropping the list of movies and tv shows it immediately drops torrent links without any criteria. Maybe there is a problem with subtitle addons that they can't find any translation. What is the purpose of this search? What exactly should throw out as a result?

antonsoroko commented 3 years ago

@matke-84

Searching from folders where movies and tv shows are working well, there is no problem with subtitles.

b/c in this case elementum operates with "real" item (item from trakt) - it has defined title, year and etc.

What is the purpose of this search? What exactly should throw out as a result?

this is a "general" search for torrent. you can use it to find something that not in trakt, like leaked episode or some educational film.

so as i can see, when you use general search, subtitles providers get some "raw" info from elementum that they usually can't parse.

i see 2 good options for this use case:

for item that exists in trakt - assign founded torrent to this item (work in progress)
for item that does not exist in trakt - use manual subtitles search in subtitles download menu (kodi has this functionality)

of course it might be possible (but might be not) to somehow change this "raw" info i mentioned before so subtitles providers start to understand it - but it seems like hard and tedious task and profit is minimal (since there are options described above). not sure that anyone will try to investigate this since it is a rare use case.

antonsoroko commented 3 years ago

a few corrections:

elementum's subs provider will use the name from search - e.g. "mymovie"
service.subtitles.opensubtitles will use "VideoPlayer.TVShowTitle" kodi's label which in this case will be like 'mymovie.2020.webdl.mp4' and it will treat it like episode and fail since it will try to convert season and episode to numbers and they are empty strings.
service.subtitles.rvm.addic7ed (only for episodes) will either use "VideoPlayer.TVShowTitle" or filename (depending of plugin settings). it will fail with TVShowTitle since there will be no episode and season numbers but will probably succeed with filename since it probably will be like "myshow s01e01.mkv"

anyway - better to assign tmdb item to torrent and forget about these issues.

elgatito / plugin.video.elementum

[Bug] Subtitle error when use elementum search option #676