search

elgatito / plugin.video.elementum

Elementum add-on for Kodi. Development of this addon has been stopped!
http://elementum.surge.sh
MIT License
484 stars 159 forks source link

[Request] Movies and tv shows studios info, number of episodes per season #684

Closed matke-84 closed 3 years ago

matke-84 commented 3 years ago

Is there a possibility to insert information about movie and tv show studios into metadata (Universal, WB, Netflix...)? It appears to me in some movies, some of them are missing. For the tv shows, I don't get information about which studio it is or for rarely tv shows appears. And the second thing, there is a possibility to insert data how many episodes contains each season? Let's say it is in some scrapers and in tmdb helper. Is it perhaps possible to fit in the elementum as well? Thanks in advance.

elgatito commented 3 years ago

@matke-84 If you know any movie/show that has information on TMDB website, that you don't see in Kodi - send examples.

matke-84 commented 3 years ago

@elgatito Studio logo missing in almost all TV shows and some movies. As for the number of seasons and episodes, that is nowhere to be found. Here is an example of Game of Thrones. IMG_20210212_191540 IMG_20210212_191519

matke-84 commented 3 years ago

@elgatito Can you please fix at least the studio logos. Somewhere they appear, somewhere they don't appear. It's little annoying. For example I don't have that problem with tmdb helper. I get every single studio logo for movie or tv show. Thanks in advance.

Bequiet19 commented 3 years ago

I have the same problem. For some movies and tv shows I have studio information for some not. If I turn on option in elementum to pull trakt information then I get all studios for all movies and tv shows but I can't use this option because I don't have fanarts then. Obviously, a small thing is a problem that only @elgatito can solve. I don't understand programming so I can't fix this.

elgatito commented 3 years ago

I do not know any way to specify studio icons to Kodi (and where to get them). I guess it's a custom functionality of a specific skin, which reads 'studio' field and try to find an icon somewhere.

If anyone has a solution - feel free to give an advice.

matke-84 commented 3 years ago

@elgatito I tried what @Bequiet19 said to turn on option in elementum to pull trakt information and studio icons really do appear for all movies and tv shows. You could also take a look at how this works in tmdb helper. With tmdb helper I also get all studio icons. I also thought it was up to my skin, but the same thing happens with all the skins I’ve tried. Since I am working on the development of one popular skin, I know that a skin helper service is necessary for showing studio icons. Maybe it will mean something to you if you want to test elementum with some skin.

elgatito commented 3 years ago

@matke-84 I do not see any studio icons in Estuary skin, in any addon. Here is the list of labels in Kodi: https://codedocs.xyz/AlwinEsch/kodi/group__python__xbmcgui__listitem.html#ga0b71166869bda87ad744942888fb5f14

matke-84 commented 3 years ago

@elgatito Wow. You managed to set up a studio logo. Thank you very much. 👍 Please tell me if there is a chance to set up elementum to provide information about number of seasons and episodes for TV shows? The skin I'm developing with a few other people has that capability and with local scrapers and tmdb helper I get that information but I don't have it with elementum.

elgatito commented 3 years ago

@matke-84 what, exactly, you need for episodes/seasons?

matke-84 commented 3 years ago

@elgatito Total seasons and total episodes per seasons. It was used in the skin as follows: IMG_20210405_220313 Screenshot_20210405_221454

matke-84 commented 3 years ago

@elgatito @antonsoroko One question. Can it be set to display network logo in tv shows instead of production studio logo. For example, The Simpsons, instead of Gracie Films to show Fox.

elgatito commented 3 years ago

@matke-84 Elementum is not setting any logos. It sends list of studios as standard information in Kodi. Then your skin decides what and where to show.

matke-84 commented 3 years ago

@elgatito I think elementum has something to do with it. Tmdb helper, for example, provides information for a TV show network. Yes, the skin helper service is in charge of this in my skin (Titan bingie mod) but it takes the information that elementum sends. If the elementum sends information about the studio instead of the network, it will display the studio logo. It's not a problem, it can stay like this, I just asked. Until recently, elementum did not even display the studio/network logo. But thanks to you, we have that now. 🙂

antonsoroko commented 3 years ago

@matke-84

so in order to try add these i would like to know how (from where) you take info to:

  1. show total count of episodes in season
  2. show total count of episodes in show
  3. show unwatched count of episodes in show
  4. show video progress percentage
  5. for logos - i think that skins are in charge to tell kodi which logo kodi should provide them. otherwise people would not be able to choose what to show as logo. if you know how skins do that (or kodi, or else) - then we can try to do something about that.

maybe you use some infolabels from https://kodi.wiki/view/InfoLabels#ListItem i see some info that can be used for that, but to be sure i want to see how you get that info in reality. (as i can see appropriate code should be in your skin's xml files)

antonsoroko commented 3 years ago

@matke-84

i did some easy changes - number of seasons/episodes and setting to choose network or production studio. probably i will not to do more sophisticated things like ListItem.Property(WatchedEpisodes) and ListItem.Property(UnWatchedEpisodes) since it will take more time than i am ready to spend on this feature. but feel free to open new feature request for these things.

please test: elementum.zip https://github.com/antonsoroko/plugin.video.elementum/archive/refs/heads/enhancements-for-skins.zip

antonsoroko commented 3 years ago

examples:

Screenshot_Kodi_20210610_000212

Screenshot_Kodi_20210610_000234

matke-84 commented 3 years ago

@antonsoroko I'm sorry, I didn't get to answer you earlier. I have a lot of work. I didn't get to test in detail but the number of seasons and episodes per season works nice as I can see. :-) Studio logo and the network logo it also works nicely. :-) I only noticed when I turn off the option you inserted to switch between the production studio and network, it doesn't work properly. Actually then I don’t get a production studio logo for every tv show. It was a problem that existed before @elgatito fixed it. But when the option is turned on it works as it should. Maybe even not need this option but if you want to keep it you need to know it has this problem. I am happy with this you make the network work properly. :-) As for the answers to your questions, I am not able to answer you in detail now, but everything important is in this file. https://github.com/AchillesPunks/skin.titan.bingie.mod/blob/matrix/xml/IncludesBingie.xml I haven't done this skin from the beginning, I got involved in its development a few months ago. I'll try to find you what you're looking for later. Skin also uses additional addons such as skin helper service, metadatautils... For example, as far as I know, metadatautils is in charge of the studio logo in skin.

antonsoroko commented 3 years ago

@matke-84

  1. Actually then I don’t get a production studio logo for every tv show.

i do get them image

please note that all these will properly work only with tmdb as source in elementum (you also can use trakt, but trakt does not give you prod companies and number of seasons are not available out of the box, only number of episodes)

before my change elementum received production_companies and networks from tmdb (see https://developers.themoviedb.org/3/tv/get-tv-details ) then combined them and set as ListItem.Studio

now it either production_companies or networks.

The only thing is when video has multiple companies/networks - skin will show text instead of logo because 2021-06-10 12:14:04.026 T:1185134 ERROR <general>: DoWork - Direct texture file loading failed for resource://resource.images.studios.white/NBC / FOX.png

Also unlike networks - prod companies often don't have logo in kodi - https://github.com/XBMC-Addons/resource.images.studios.white/tree/master/resources

e.g. `2021-06-10 12:22:00.978 T:1194926 ERROR : DoWork - Direct texture file loading failed for resource://resource.images.studios.white/CBS Television Studios.png

this is true at least for skin.aeon.nox.silvo

maybe it makes sense to provide not all "studios" but only first one. i dunno.

  1. https://github.com/AchillesPunks/skin.titan.bingie.mod/blob/matrix/xml/IncludesBingie.xml

    that's a lot of text :-) okay, if we will have some issues, then we can try to read it.

matke-84 commented 3 years ago

@antonsoroko It gives me information for seasons and episodes for both in trakt and tmdb at least what I saw. Yes, you are right. You actually get information about the studio or network, but if there is no image, the skin will not show it. In fact elementum before used it to mix network and studio, so if there is no one, you get the other and that was ok too but now I will definitely use network for the tv shows because it makes sense to me for tv shows. This second option with the production studio is only interesting if something would be combined again because in this way it remains empty space in skins like mine. If we keep this function I would just move it to appearance tab. No studio no studio With sudio with studio Yes, there is a lot of text. :-) I'll see if I can send it to you for: 3.show unwatched count of episodes in show 4.show video progress percentage We don't need for rest now or maybe we need it? :-)

antonsoroko commented 3 years ago

i see. but this is issue of the skin to be honest. standard skin shows everything. your skin also can do that.

I would just move it to appearance tab.

will do.

  1. my guess is that skins either calculate it by subtracting ListItem.Property(WatchedEpisodes) from ListItem.Property(TotalEpisodes) or by using ListItem.Property(UnWatchedEpisodes) if available
  2. my guess is ListItem.PercentPlayed

but please check.

matke-84 commented 3 years ago

@antonsoroko No no. I agree with everything. In your skin, it displays text instead of a logo it can't find. It's OK. In my skin, it works like I said, an additional addon, metadatautil, probably in a different way. It is enough for me to show me the network for the tv shows. :-) The movies have worked fine so far. Can you just tell me if it shows you the logo for Star Wars Rouge One od Star Wars The Last Jedi? That's where I noticed I didn't have a logo.

You're all right. :-) I'm sending you just to see what some lines of code look like. For total seasons: https://github.com/AchillesPunks/skin.titan.bingie.mod/blob/c9bc2d988161997b5708429ec75a0142cba7f4c2/xml/IncludesBingie.xml#L879 Watched info: https://github.com/AchillesPunks/skin.titan.bingie.mod/blob/c9bc2d988161997b5708429ec75a0142cba7f4c2/xml/IncludesBingie.xml#L2692 Percent played: https://github.com/AchillesPunks/skin.titan.bingie.mod/blob/c9bc2d988161997b5708429ec75a0142cba7f4c2/xml/IncludesBingie.xml#L3232

antonsoroko commented 3 years ago

  1. yes, for both. because they have only 1 prod company (there is no network for movies in tmdb, which i guess is correct). but for movies that has more than 1 company - i get them as text. as i said

    maybe it makes sense to provide not all "studios" but only first one. i dunno.

    but then it will be inaccurate :-) but also this is for standard skin, your skin probably can take first studio by itself.

  2. okay, all these 3 things are not quick to implement, so i will not do this now. but i created a issues for them.

matke-84 commented 3 years ago

@antonsoroko

  1. Forget this. :-) Star Wars logo works with white logo. There is probably some problem with color logo. It doesn't matter so much.
  2. Ok. Sounds good. I am here for every kind of help. If you need something to test feel free to contact me. ;-)