search

elgatito / plugin.video.elementum

Elementum add-on for Kodi. Development of this addon has been stopped!
http://elementum.surge.sh
MIT License
474 stars 157 forks source link

[Feature Request] Rate videos after playback #779

Open antonsoroko opened 3 years ago

antonsoroko commented 3 years ago

Expected Behavior

Ask user to rate video after playback. Send this rating to trakt.

Current Behavior

Possible Solution

i guess we need some custom dialog that we can borrow from https://github.com/trakt/script.trakt/blob/main/resources/skins/Default/720p/script-trakt-RatingDialog.xml or https://github.com/Regss/script.user.rating/tree/master/resources/skins/Default/720p and then use this api call https://trakt.docs.apiary.io/#reference/sync/add-ratings/add-new-ratings

also we can add menu item to rate videos without playing.

in the end it should look like https://github.com/trakt/script.trakt/blob/main/resources/image-01.png

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

elgatito commented 3 years ago

@antonsoroko script.trakt is asking for a rating, if played item has proper Trakt/TMDB ID defined. On my devices almost always asks for a rating.

antonsoroko commented 3 years ago

@elgatito hm. does it work with elementum items (that are not added to lib)? (i am curious because now we set tmdb id. and we also can set trakt id if needed) if yes - then i guess it does not make much sense to re-implement the wheel. although i would prefer to have only 1 addon.

elgatito commented 3 years ago

@antonsoroko can't answer that. It does not ask 100% of times, so there are situations when rating is not asked, but I don't know why.

antonsoroko commented 3 years ago

i installed it and i will try to test it. but i already can see that it has many features that intersects with elementum. except rating. so it probably still make sense to implement this.

antonsoroko commented 3 years ago

i enabled only rating feature - it never asked me to rate anything. but i do not have library integration on my main device. although they have the option for "addons videos". looks like more technical investigation is needed.