elgatito / script.elementum.burst

Development of this addon has been stopped!
MIT License
117 stars 117 forks source link

RFC: Switch to script.module. instead of vendoring modules #423

Open antonsoroko opened 6 months ago

antonsoroko commented 6 months ago

Idea: maybe it would be easier to support different kodi version if instead of vendoring burst will use appropriate script.module. ? i mean: specific script.module is supposed to work with specific kodi version. so no need for burst to have some magic version of modules that works with all kodis.

looks like almost all modules from resources/site-packages/ exists as script.module for all modern kodis. https://mirrors.kodi.tv/addons/omega/ https://mirrors.kodi.tv/addons/nexus/ https://mirrors.kodi.tv/addons/matrix/ https://mirrors.kodi.tv/addons/leia/ https://mirrors.kodi.tv/addons/krypton/

i see certifi, chardet, idna, requests, urllib3. (also simplejson that is used by elementum also there)

only kodi 16 lacks modules https://mirrors.kodi.tv/addons/jarvis/

if burst still wants to support kodi 16 for some reason then maybe with such approach burst can keep old modules in resources/site-packages/ for kodi 16, and use script.module.* for other kodis.