search

elgatosf / streamdeck-philipshue

Stream Deck SDK: Philips Hue sample plugin
https://developer.elgato.com/documentation/stream-deck/
MIT License
201 stars 44 forks source link

Is a overall code cleanup wanted? #20

Closed dkern closed 2 years ago

dkern commented 3 years ago

Hello @elgatosystems

In my last pull requests (https://github.com/elgatosf/streamdeck-philipshue/pull/7, https://github.com/elgatosf/streamdeck-philipshue/pull/19) I already added a lot of code quality improvement wherever I saw them. But I still didn't touched the bigger issues. Like switching from function() {} to arrow functions, general update to newer JavaScript functions and techniques or remove all usage of var, like used for global variables and switch to a more robust approach.

But before I would do this, I would like to ask if you would want me to do this? I would like to update to a new and robust structure and improve anything on the way. 😉

Please let me know what you think!

tiptronic commented 3 years ago

Hi @dkern hi @all,

thanks for providing fixes and improvements to the repo, all of which are very welcome.

Just let me note something: the plugin was just meant as a sample plugin to show how to integrate Third-party accessories using standard HTML/CSS/Javascript. It was not meant as a 'full-fledged' (long-standing) integration, because we expected the manufacturer of the accessories to build their own.

Since you all are pretty active here and seem to care about the plugin, I will happily assist improving the plugin. So this is not an official project, but I'll do my best...

Cheers

andy PS: So feel free to add issues and pull-requests...

dkern commented 3 years ago

Hello @tiptronic ! I'm not sure if I got you correct or not. So you will improve the plugin and we'll stay away? Or do you want help for cleanup, code improvements and renew things? I'm not completely sure what you want to say. ;)

tiptronic commented 3 years ago

Hi @dkern ,

the other way round ;) - I'll see what I can do to help you improving the plugin, so it fit's your needs... ;)

dkern commented 2 years ago

@tiptronic @elgatosystems

Would some of you be so kind to close some tickets? That would help me to keep track. 😉

These are already resolved:

These are unsolvable:

And these are just old and could not verified:

Thank you!

tiptronic commented 2 years ago

Hey @dkern thanks for taking care of the issues and cleanup... I closed the ones you requested.

dkern commented 2 years ago

Hey @tiptronic

Thanks very much, thats already better. ;) Would you like to close the other two too, i linked above? I already commented on them, so its clear why they could be closed (i think).

I will take a look to the remaining two issue by time.