elgentos / LargeConfigProducts

Large Configurable Products workaround for Magento 2
91 stars 28 forks source link

Frontend fetch does not take store view into account #20

Closed lfglopes closed 5 years ago

lfglopes commented 5 years ago

On the frontend side of things, the configurations seem to be loaded from the following endpoint:

/lcp/fetch/productOptions?productId=:productId

Turns out I have two different store views for each language, and the results for the default language always come out. If I change the endpoint to, say,

/de/lcp/fetch/productOptions?productId=:productId

Then the right results come out.

peterjaap commented 5 years ago

Aah right, good catch. In the project we've built this for we use separate domains so we hadn't run into this yet. Could you do a PR?

lfglopes commented 5 years ago

sure

lfglopes commented 5 years ago

I guess this is fixed now :)

I'll take the opportunity to thank you guys for publishing this piece, you saved me (and others I can assume) from a good headache. ;)

peterjaap commented 5 years ago

@lfglopes and thank you for your contribution :raised_hands: