elgentos / LargeConfigProducts

Large Configurable Products workaround for Magento 2
91 stars 28 forks source link

VAT is possibly incorrect when using prewarmer #23

Open peterjaap opened 5 years ago

peterjaap commented 5 years ago

I noticed that the ex VAT prices in the prewarmer-generated JSON will always use the tax percentage of the base store. This also (like prices themselves and attribute option value translations) does not take the storeview in account when run through the bin/magento console command.

This means that the ex VAT prices are possibly incorrect (if a the storeview uses a different tax percentage than the default storeview). However, since the JSON is only used on the product page for display purposes, this only poses an issue when you show excluding VAT prices on the frontend.

I haven't had time to fix this yet so this is just a placeholder issue for when I (or somebody else) encounters this.