search

elgentos / LargeConfigProducts

Large Configurable Products workaround for Magento 2
91 stars 28 forks source link

Compatibility 2.2.7 or 2.3 #27

Closed simonmaass closed 5 years ago

simonmaass commented 5 years ago

any experience/feedback about this?

peterjaap commented 5 years ago

I went through the extension file for file and checked the changes in the source file (so the file that is rewritten/pluginized). Here are my results:

lib/internal/Magento/Framework/View/TemplateEngine/Xhtml/Template.php last change on Feb 22, 2017 so we're good.

app/code/Magento/Swatches/Block/Product/Renderer/Configurable.php 2 recent changes; this one and this one, no relevant code for us changed.

app/code/Magento/ConfigurableProduct/Model/AttributeOptionProvider.php: last change on May 30, 2017 so we're good.

app/code/Magento/ConfigurableProduct/Pricing/Price/LowestPriceOptionsProvider.php: last change on March 3 2018, so that was 2.2.3 so we're good.

app/code/Magento/Swatches/view/frontend/templates/product/listing/renderer.phtml has one change from Oct 10th 2018, but since we basically remove everything in that file, we're still good.

app/code/Magento/Catalog/view/frontend/templates/product/view/options/wrapper.phtml - last change on June 6th, 2017 so we're good.

app/code/Magento/ConfigurableProduct/view/frontend/web/js/configurable.js - only changes in _getPrices() but we don't overwrite that method in our mixin so we're good.

app/code/Magento/Swatches/view/frontend/web/js/swatch-renderer.js - bunch of updates but none related to init or updateBaseImage, which we are overwriting.

app/code/Magento/ConfigurableProduct/view/frontend/web/js/configurable-customer-data.js - no change since September 2, 2016 so we're good.

Which pretty much means that on a superficial file by file level, we're good :tada:

I've done some preliminary testing on 2.2.7 and everything there seems to be in order, YMMV.

Concerning 2.3.0; since Magento now ships with Magento_MessageQueue, for 2.3 we can remove the dependency on renatocason/magento2-module-mq. So it will most likely still work OK but we should move the Magento's own MQ implementation over time (see for more info here - issue #28).

simonmaass commented 5 years ago

I can confirm that it works on 2.2.7

simonmaass commented 5 years ago

@peterjaap any idea when you will get to that - concerning the queue?

peterjaap commented 5 years ago

It seems that it works on 2.2.7 and 2.3.0. Concerning the queue, check #28 for updates (haven't worked on it since).