Luma tests for Cypress - Githubissues

elgentos / magento2-cypress-testing-suite

A community-driven Cypress testing suite for Magento 2

MIT License

172 stars 37 forks source link

Luma tests for Cypress #23

Closed peterjaap closed 2 years ago

peterjaap commented 2 years ago

@vladhorielov thanks for your work! I do have a number of issues with this though.

You copied all files, even though the content is the same (or very very similar). This means code duplication, which is not what we want
We want to avoid having if statements in the code as much as possible. It would be great if we could find a nicer way to switch to Luma instead of Hyvä. Maybe let the spec files point to a specific location and symlink that location to either the Hyvä or the Luma folder?
If a Luma test differs from the Hyvä version aside from the selector fixtures, please create a separate test for it instead of having an if-statement INSIDE the test. This will allow developers to only copy the relevant tests from the suite into their project, which leads to less code.

peterjaap commented 2 years ago

So right now we have;

cypress/integration/cart/*.spec.js
cypress/integration/checkout/*.spec.js
cypress/integration/product/*.spec.js
etc

We want to have;

cypress/integration/hyva/cart/*.spec.js
cypress/integration/hyva/checkout/*.spec.js
cypress/integration/hyva/product/*.spec.js
etc
cypress/integration/luma/cart/*.spec.js
cypress/integration/luma/checkout/*.spec.js
cypress/integration/luma/product/*.spec.js

Same goes for fixtures and page objects.

When we have that, we can easily see which files are 100% the same, or which are very similar, and see if we can refactor to a certain base point. If not, we just leave them separate files.

peterjaap commented 2 years ago

@vladhorielov thanks, that's awesome! Few points;

Could you fix the merge conflicts?
Could you remove all the useless .DS_Store files?
Could you move the selectors dir into the hyva and luma dirs?

Right now this is the structure;

cypress/fixtures/hyva
cypress/fixtures/luma
cypress/fixtures/selectors/hyva
cypress/fixtures/selectors/luma

I want it to be this;

cypress/fixtures/hyva/selectors
cypress/fixtures/luma/selectors

Another question; why are you manually removing localstorage and cookies? Cypress removes those automatically on each run.

vladhorielov commented 2 years ago

@peterjaap Could you fix the merge conflicts? - done ✅ Could you remove all the useless .DS_Store files? - done ✅ Could you move the selectors dir into the hyva and luma dirs? - done ✅