Refactor & cleanup Luma Account tests & objects

elgentos / magento2-cypress-testing-suite

A community-driven Cypress testing suite for Magento 2

MIT License

172 stars 37 forks source link

Refactor & cleanup Luma Account tests & objects #90

Open gregor-RW opened 2 years ago

gregor-RW commented 2 years ago

Running the tests on a different CI with smaller resources, I've noticed a few issues around:

sessions being lost (from cypress doc: Cypress automatically clears all cookies before each new test starts by default.)
multiple addresses being added while running the whole batch
some code cleanup to make sure to use proper selectors where possible
added region/state selectors for the address

gregor-RW commented 2 years ago

@peterjaap I modified the details for Luma and for some reason Hyva is failing. Since I don't have access to Hyva to fix it, I can't proceed here. Maybe the whole refactor doesn't make sense to you, so feel free to reject the whole thing.

Vinai commented 2 years ago

I don't think the luma failures are related to these changes.

gregor-RW commented 2 years ago

@Vinai I'm only seeing Hyva failures, not Luma. Am I missing something?