Missing rewrite for overwritten url_key

[mortenbirkelund]

I think i have found a scenario where the module is not generating all urls rewrites correctly.

• Create 2 Websites, 2 Stores and 2 storeviews.

• Set the 2 stores to be using the same root category.

• Create a category, and change the scope to one of either storeviews before changing the url key.

• You should now have 2 url rewrites (and 1 url redirect, but that is not relevant. )

• Regenerate category urls and see that only 1 of the 2 rewrites are properly created.

• Confirm by deleting both of the 2 rewrites, and regenerate them. Only the storeview that inherits from global, will have a url rewrite correctly generated.

[mortenbirkelund]

Hmm. I seem a bit silly documenting all of these steps only to see afterwards that this is exactly what #49 is addressing. However it seems strange that you would have to know yourself which categories belongs to a storeview . If you run the command for a storeview, where the category is not included in, then the rewrite is still created. So you would have to know exactly which categories to create for each storeview.

[peterjaap]

@mortenbirkelund so basically you want to add the all store option to the category command as well? And/or set it to the default?

[mortenbirkelund]

Yes basically. Set it as the default or as an option depends, at least in my mind, on how it will work.

If it only creates the same rewrites that magento would also have done itself, then I think it should be default. But if it forcefully generates for all storeview regardless, then It would be better as an option.

What do you think?

[peterjaap]

I agree, it doesn't really matter which we pick, as long as it is consistent. I'm closing this issue in favor of #58 , which should fix this.