search

elgerlambert / redux-localstorage

Store enhancer that syncs (a subset) of your Redux store state to localstorage.
MIT License
1.32k stars 107 forks source link

Bug in persistState.js #10

Closed Graf009 closed 9 years ago

Graf009 commented 9 years ago

The code persistState.js https://github.com/elgerlambert/redux-localstorage/blob/1.0-breaking-changes/src/persistState.js#L40 uses a variable "finalReducer", but I think that there should "reducer"

elgerlambert commented 9 years ago

I was afraid something like this would happen. I'm away for the next three weeks.. could you do me a favour and create a PR to fix this bug? Can't fix it myself, but I'll be able to accept a PR.

My apologies!

0x80 commented 9 years ago

I'm trying to install the module including this patch with npm install elgerlambert/redux-localstorage#4b2e1a8, but the resulting module folder only contains a README and a package.json. Is that not the correct way to install an npm module from a specific commit?

chrishoage commented 9 years ago

@0x80 This npm module is written in ES6, so it requires a compile step. In the .npmignore file it contains src which causes npm to remove that folder when installing though git making the compile step impossible.

The only way to use the RC currently is to check out the project separate from npm, run npm prepublish and then npm link until @elgerlambert can release a new RC with the fix.

0x80 commented 9 years ago

Thanks @chrishoage that makes total sense!

elgerlambert commented 9 years ago

Hi guys, the fix for this issue has just been published to npm as rc4. Apologies for the delay (currently traveling with infrequent access to wifi and I only have a tablet with me).