search

elgerlambert / redux-localstorage

Store enhancer that syncs (a subset) of your Redux store state to localstorage.
MIT License
1.32k stars 107 forks source link

Push v1 changes to NPM #32

Closed hoodsy closed 8 years ago

hoodsy commented 8 years ago

@elgerlambert Per the discussion in #13, it would be really nice if you could push the changes to npm.

Currently, I have to patch my version with the code from the PR.

MattiSG commented 8 years ago

+1

stoikerty commented 8 years ago

+1

hoodsy commented 8 years ago

Interestingly enough, I was having the same error from the PR with rc4. Copying in the PR elevated this error.

On Tuesday, February 2, 2016, Jorge Antunes notifications@github.com wrote:

@hoodsy https://github.com/hoodsy @MattiSG https://github.com/MattiSG

Before it is merged into master, you can install v1 using package@version

npm install --save redux-localstorage@1.0.0-rc4

— Reply to this email directly or view it on GitHub https://github.com/elgerlambert/redux-localstorage/issues/32#issuecomment-178514896 .

TuckerCowie commented 8 years ago

+1

gabadi commented 8 years ago

+1

gingermusketeer commented 8 years ago

@elgerlambert Anything I can do to help get the v1 release out?

ezekielchentnik commented 8 years ago

agreed, been patching ... anything i can do to help?

seansfkelley commented 8 years ago

This issue has been around for months, so I just went ahead and published a fork for the express purpose of getting this fix in. Hopefully I can obsolete it soon.

elgerlambert commented 8 years ago

Hi all,

A new version has finally been released, version 1.0.0-rc5 is now available on npm!

I'm really sorry I didn't do this sooner. For the past half year or so I wasn't working on any react/redux projects and became unsure about the direction 1.0 was heading. That's now changed and I've been using redux-localstorage in production for the past month, this has helped me feel the pain points and unblock myself.

Once again, my appologies. Thanks @seansfkelley for jumping in and publishing a fork! rc5 should resolve most of the issues and PR's that are open. Please try it out and let me know if you guys bump into any unresolved issues!

seansfkelley commented 8 years ago

Thanks! I added a deprecation notice and a link here to my fork and pushed that to npm.

elgerlambert commented 8 years ago

Thanks again @seansfkelley!