Closed elgg-gitbot closed 11 years ago
elgg-gitbot
commented
11 years ago ewinslow wrote on 2012-04-05
Usually you would unregister menu items from the register, menu:$menu plugin hook, no? Unregistering menu items from a view seems to not be a great standard we want to encourage.
I could be completely missing something though.
elgg-gitbot
commented
11 years ago brettp wrote on 2012-04-10
Evan is right. If we're missing something, please reopen with more details.
elgg-gitbot
commented
11 years ago trac user ismayil.khayredinov wrote on 2012-04-10
Can't remember what the exact issue was now. This would still make sense for the sake of consistency.
elgg-gitbot
commented
11 years ago trac user Ismayil Khayredinov wrote on 2012-06-19
Fixes (Trac Ticket 4395): Register group profile title buttons earlier Changeset: b4ad258a325ebda8b78641f31b10dbd04fb724ce
elgg-gitbot
commented
11 years ago trac user Cash Costello wrote on 2012-06-19
Merge pull request (Trac Ticket 183) from hypeJunction/group_title_button
Fixes (Trac Ticket 4395): Register group profile title buttons earlier - registering menu items before rendering the layout Changeset: b0200823eb63940a23c33257758d2a8dc42ca25a
elgg-gitbot
commented
11 years ago trac user Ismayil Khayredinov wrote on 2012-06-23
Fixes (Trac Ticket 4395): Register group profile title buttons earlier Changeset: b4ad258a325ebda8b78641f31b10dbd04fb724ce
elgg-gitbot
commented
11 years ago trac user Cash Costello wrote on 2012-06-23
Merge pull request (Trac Ticket 183) from hypeJunction/group_title_button
Fixes (Trac Ticket 4395): Register group profile title buttons earlier - registering menu items before rendering the layout Changeset: b0200823eb63940a23c33257758d2a8dc42ca25a
Original ticket http://trac.elgg.org/ticket/4395 on 2012-03-01 by trac user ismayil.khayredinov, assigned to unknown.
Elgg version: 1.8.3
in group_handler_profile_page(), profile buttons should be registered earlier, so there is a possibility unregister them from one of the views