elgiano / nn.ar

nn_tilde adaptation for SuperCollider
GNU General Public License v3.0
30 stars 4 forks source link

Does not work in ProxySpace #2

Closed mantsar closed 1 year ago

mantsar commented 1 year ago

Hi, thanks for this amazing implementation!! Works great however I get error while using proxyspace:

p = ProxySpace.push(s);
NN.load(\rave, "~/rave/percussion.ts");
NN(\rave).describe;
^^ ERROR: Message 'models' not understood.
elgiano commented 1 year ago

Hey, thanks a lot for this report! It's actually a design problem. I'm currently re-structuring the scsynth part, so I can't fix it really fast... but here is an idea if you want to fix it yourself in the meanwhile:

The problem is in NN.isNRT, which is currently implemented like this:

*isNRT { ^currentEnvironment[\nn_nrt].notNil }

as a temporary fix, we could change it to this:

*isNRT {
    ^currentEnvironment[\nn_nrt].notNil and: {
        currentEnvironment[\nn_nrt][\models].notNil
    }
}

Let me know how it works for you :)

mantsar commented 1 year ago

@elgiano Tried with new update and it works great!

elgiano commented 1 year ago

fixed in v.0.0.3-alpha