search

elgorditosalsero / react-gtm-hook

Easily manage the Google Tag Manager via Hook
https://elgorditosalsero-react-gtm-hook.netlify.app/
MIT License
220 stars 28 forks source link

Remove "console.log('CUSTOOOOM DOMAIN', customDomain);" within initGTM #66

Closed florianmatz closed 2 years ago

florianmatz commented 2 years ago

In Line 49 of GoogleTagManager.ts

a quite scandalous console.log() happens.

https://github.com/elgorditosalsero/react-gtm-hook/blob/d649f16bd04698a0f6b10ead2958bd1787c08dff/src/utils/GoogleTagManager.ts#L49

Could it be removed?

florianmatz commented 2 years ago

@thebiltheory It seems, that you haven't remove a development logging?

thebiltheory commented 2 years ago

@florianmatz oops😂. It sure can. Is it bothering you for now?

florianmatz commented 2 years ago

@thebiltheory :P - kind of - I want to use the package in one of our client portals and it feels a bit glitchy to have strange logs in my business prod code :)

I've seen, there is already an open PR for that. @elgorditosalsero do you mind approving it?

elgorditosalsero commented 2 years ago

Closing due #64