Open Zeredbaron opened 3 weeks ago
r? @eli64s
Hi @Zeredbaron, thanks for the PR! I just did some testing to ensure we're handling edge cases correctly, specifically when language
is None
or an empty string ''
.
Your PR #110
Current Implementation
This analysis suggests the current implementation works as intended, excluding all None
and empty string ''
values. However, it looks like we found a new issue as the function does not properly handle empty strings that contain one or more whitespaces ' '
or " "
.
This issue is not related to your PR, but would be good to fix to take a look at! We'll need to update the count_languages
method on line 38 to strip whitespace and check for empty strings. This should ensure only valid language entries are counted in the returned dictionary.
Let me know if you have any questions or if you'd like to tackle this improvement 🙂
Eli
Removes extra language variable from quickstart.py