search

elias-sundqvist / obsidian-annotator

A plugin for reading and annotating PDFs and EPUBs in obsidian.
GNU Affero General Public License v3.0
1.49k stars 68 forks source link

[BUG] Obsidian hotkey not working in annotation mode #161

Open StrangeArmadillo opened 2 years ago

StrangeArmadillo commented 2 years ago

Hi! Thank you for your nice work, I noticed that when I'm annotating a pdf the obsidian hotkey aren't responding: instead the program recognize only the one of the annotator tool (i.e. Ctrl+P launch the print dialog instead of the Command palette).

It would be really nice if you can say which set of hotkeys consider directly from the plugin settings (I work a lot with metaedit and losing the keyboard shortcut for launching that plugin takes a lot from your plugin, already high, utility), if this is feasable to you :)

Thank you in advance!

Lord-Leonard commented 2 years ago

+1

tinkerrc commented 2 years ago

Currently, a workaround is to click the tab bar (where the title is) and retry the hotkey. It seems that when the annotator tool has the focus, none of the Obsidian hotkeys would work (not even the one used to toggle annotation mode).

aladmit commented 2 years ago

when the annotator tool has the focus, none of the Obsidian hotkeys would work That's right :(

I dived into the issue a few days ago. That happens because pds/epub reader and annotator run inside an iframe. It takes all key events, so obsidian itself can't see them. I'll try to duplicate all key events from iframe into global window and see if it helps.

alexisthual commented 2 years ago

Did your approach work @aladmit ? :slightly_smiling_face:

aladmit commented 2 years ago

Still haven't tried it, sorry 😬

alexisthual commented 2 years ago

No problem! It's a nice-to-have but not a critical feature. I'd happily to do a code review if you come up with a PR and you think that's of any help!

Gewerd-Strauss commented 1 year ago

It's a nice-to-have but not a critical feature.

I'd strongly disagree with that assumption. Obsidian in and of itself is pretty good when it comes to hotkey coverage, and most plugins allow detailed hotkeys as well. The issue here imo is that a lot of the workflow relies on these hotkeys working, and doing so in a uniform fashion. Not to mention that stuff like link embedding is quite tedious without hotkeys (or even better, the wonderful URL-into-selection Settings-plugin). Now, obviously I wouldn't expect every plugin to be cross-compatible with others. However I do believe that hotkey support, if only for obsidians default hotkeys, is really necessary. The annotation workflow is simply too complicated if I must use the mouse every half sentence when writing a detailed annotation for "whatever scientific paper I am reading at the time".