search

eliascotto / export-kobo

A Python tool to export annotations and highlights from a Kobo SQLite file. Now with web UI.
MIT License
26 stars 2 forks source link

Removed unused ExtraAnnotationData column #5

Closed eliascotto closed 3 months ago

eliascotto commented 4 months ago

Fixing issue #4, tested on Kobo Aura HD. Need help testing on another device, especially Kobo Libra Colour.

steeltrap commented 4 months ago

Hello! Thanks for your response.

I have tested with my device (Kobo Libra Colour) and it now returns without error. But I think it's slightly more complicated than first thought!

When I first tried using your program, the previous version produced an error - since then I've been using the device a bit more. Now the same old script with an updated version of the database file does not produce an error. However, less data is being produced by the program with the new database (with either the original or new version of the script).

Testing results:

Program version Old DB New DB
Original (Error) 214 lines, 7.3k
Current 758 lines, 27k 214 lines, 7.3k

So yes this PR fixes the original syntax error. But something has changed in the DB in the meantime. Either the annotations age-off or perhaps there's a different bug somewhere? The new SQL file is larger than the old one - so I suspect the data is still in the new file, even though the output is now smaller.

I'd be happy to share the SQL files if that would be helpful?

eliascotto commented 3 months ago

Thanks for the detailed testing. Yes, having a copy of the SQL file would be helpful in you can attach it.

For now I'm merging this PR since it resolve the original problem.