search

eliasdoehne / stellaris-dashboard

A graph dashboard and event log for Stellaris.
122 stars 14 forks source link

Add a 3.10.4 vanilla save to test cases #129

Closed chennin closed 2 months ago

chennin commented 7 months ago

Add an updated vanilla save from 3.10.4. It was generated on a huge galaxy by letting observer mode run for 300 years (then saved in non-observer mode). This save specifically tests both accented characters and names literally =, ie, #126. It also has newer features like council positions.

Also modifies the test case to remove all *.db files output by the test.

⚠️ Please merge after #124 and #128

eliasdoehne commented 7 months ago

I like the idea of testing the code with a real save file, but I think we'll need a different way to store the files since they will quickly increase the size of the repo if we add new ones on every release.

Maybe we can just move them to a separate repo and clone it during the github action workflow. Or something like this? https://docs.github.com/en/repositories/working-with-files/managing-large-files (I never tried it)

@chennin @MichaelMakesGames Do you have any ideas for this?

chennin commented 7 months ago

@chennin @MichaelMakesGames Do you have any ideas for this?

@eliasdoehne I tried Git LFS and it seems it won't work for the usual model of collaborators using forks to code and open PRs.

batch response: @chennin can not upload new objects to public fork chennin/stellaris-dashboard
error: failed to push some refs to 'github.com:chennin/stellaris-dashboard.git'
chennin commented 2 months ago

Closing this in favor of an upcoming different solution