eliasdoehne
commented
1 year ago Yes, having consistent (or at least similar) colors would be a huge improvement! I tried this before but could never finish it due to time limitations.
I added parsing of the empire's colors from the save. In the save format don't know what the 3rd and 4th are, but the 1st is the primary color (map border) and the 2nd is the secondary (map fill). Anyone know what the others represent, if present?
I had the same question and didn't manage to fully figure it out at the time. I believe it's actually a different file that is relevant here: flags/colors.txt, it looks like this one controls the exact shade to be used in different contexts (flag, map, ship) as well as the combinations of colors that may be assigned together, it is split into two sections which look like this:
colors = {
dark_brown = { flag = rgb { 58 38 23 } map = rgb {107 68 40} ship = rgb {255 228 136 } }
brown = { flag = rgb { 101 66 40 } map = rgb {156 91 45} ship = rgb {255 228 136 } }
...
}
randomizable_combo = { orange black orange }
randomizable_combo = { black orange orange }
...This is also one of the files that is modified by country color mods like this one, so I'm pretty sure that it's the right place.
I am not sure how the colors in the save file map to this. I think one of the additional colors might be used if the country is part of a federation or some similar in-game condition? But this is just a guess.
I didn't find a way to either ignore the missing column error or auto migrate. I could write a one-time migration script that adds the columns manually?
I researched this before and at some point just accepted that there will be breaking changes like this from time to time and decided not to worry too much about backwards compatibility. It means that users will have to start a new game, but this usually happens with every major game update anyway. When I have time to work on the dashboard, I usually start with non-breaking updates first so anyone stuck on the old version can at least get one more round of bug fixes. That said, if you have some idea or experience for handling migrations in sqlalchemy that doesn't add much work, I would reconsider it.
I'm not sure how to handle when two empires have the same color
Good question, we can first try draw some borders as you suggested. I'll have another look at the scipy Voronoi data structure. Maybe I can make some small example work. Alternatively (or additionally), we can apply some small hue offset based on a hash of the country name, similar to the current approach. Or we check the number of countries with the same color and space it out evenly over some range
Overall from taking a look at the code, I think your solution is quite good. The only bigger change I would add is to obtain the available colors at runtime, similar to how the localization of names is handled. I think it is quite common to mod and it would be great to have compatibility with that.
chennin
MichaelMakesGames
Hi, so first off, I have a branch where this is "done", but there's several maybe-issues and I'm not sure I like the design. So this is to discuss.
Second, it looks like this: https://imgur.com/a/f75FweM (Serious Empire is shadow_blue/white, Vulpes is orange/black, Mandasura is blue/black, and Zaxxod is dark_brown/blue)
Discussion:
visualization_data.get_color_vals()which is the lowest-level color picking function and now does a database call. So I also implemented some storing of the colors in a few higher places. I'm not sure I like this design. But I wasn't sure where else to do the database calls, or where best to cache the retrieved colors. Thoughts?