eliasgranderubio / dagda

a tool to perform static analysis of known vulnerabilities, trojans, viruses, malware & other malicious threats in docker images/containers and to monitor the docker daemon and running docker containers for detecting anomalous activities
Apache License 2.0
1.15k stars 160 forks source link

Securing the Dagda REST API by using HTTPS #40

Open eliasgranderubio opened 5 years ago

eliasgranderubio commented 5 years ago

Short description

Securing the Dagda REST API by using HTTPS

Actual results

The Dagda REST API doesn't support HTTPS

Solution

The Dagda REST API supports HTTPS

denzuko commented 5 years ago

if one is supporting traefik as default then traefik already can create the tls certificate via acme.

One may also be able to accept a tls keypair via a docker secret/config or even include something like veeti/manuale within the startup script.

I'll be glad to submit a PR on this if one based on the suggestions above.

eliasgranderubio commented 5 years ago

The idea of this issue is the WSGI server will support HTTPS without any other external component and therefore, Dagda should include as command line parameters all necessary for that.

eliasgranderubio commented 4 years ago

Pending the evaluation between Gunicorn and Waitress.