search

eliashaeussler / typo3-badges

🌍 Symfony project with SVG and JSON endpoints for beautiful TYPO3 badges
https://typo3-badges.dev
GNU General Public License v3.0
11 stars 2 forks source link

[FEATURE] Let badge providers handle color values individually #727

Closed eliashaeussler closed 1 year ago

eliashaeussler commented 1 year ago

Since color values are different between badge providers, each provider now handles the values by its own. For this, a new Color enum is added. In addition, the badge entity properties are hardened a little bit.

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit aae2de8c and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 99.7% (0.0% change).

View more on Code Climate.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 :tada:

Comparison is base (b5e732b) 99.71% compared to head (aae2de8) 99.73%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #727 +/- ## ============================================ + Coverage 99.71% 99.73% +0.01% + Complexity 100 96 -4 ============================================ Files 21 21 Lines 349 372 +23 ============================================ + Hits 348 371 +23 Misses 1 1 ``` | [Impacted Files](https://app.codecov.io/gh/eliashaeussler/typo3-badges/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Elias+H%C3%A4u%C3%9Fler) | Coverage Ξ” | | |---|---|---| | [src/Badge/Provider/BadgeProviderFactory.php](https://app.codecov.io/gh/eliashaeussler/typo3-badges/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Elias+H%C3%A4u%C3%9Fler#diff-c3JjL0JhZGdlL1Byb3ZpZGVyL0JhZGdlUHJvdmlkZXJGYWN0b3J5LnBocA==) | `100.00% <ΓΈ> (ΓΈ)` | | | [src/Value/NumberFormatter.php](https://app.codecov.io/gh/eliashaeussler/typo3-badges/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Elias+H%C3%A4u%C3%9Fler#diff-c3JjL1ZhbHVlL051bWJlckZvcm1hdHRlci5waHA=) | `100.00% <ΓΈ> (ΓΈ)` | | | [src/Badge/Provider/BadgenBadgeProvider.php](https://app.codecov.io/gh/eliashaeussler/typo3-badges/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Elias+H%C3%A4u%C3%9Fler#diff-c3JjL0JhZGdlL1Byb3ZpZGVyL0JhZGdlbkJhZGdlUHJvdmlkZXIucGhw) | `100.00% <100.00%> (ΓΈ)` | | | [src/Badge/Provider/ShieldsBadgeProvider.php](https://app.codecov.io/gh/eliashaeussler/typo3-badges/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Elias+H%C3%A4u%C3%9Fler#diff-c3JjL0JhZGdlL1Byb3ZpZGVyL1NoaWVsZHNCYWRnZVByb3ZpZGVyLnBocA==) | `100.00% <100.00%> (ΓΈ)` | | | [src/Controller/DefaultBadgeController.php](https://app.codecov.io/gh/eliashaeussler/typo3-badges/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Elias+H%C3%A4u%C3%9Fler#diff-c3JjL0NvbnRyb2xsZXIvRGVmYXVsdEJhZGdlQ29udHJvbGxlci5waHA=) | `100.00% <100.00%> (ΓΈ)` | | | [src/Entity/Badge.php](https://app.codecov.io/gh/eliashaeussler/typo3-badges/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Elias+H%C3%A4u%C3%9Fler#diff-c3JjL0VudGl0eS9CYWRnZS5waHA=) | `100.00% <100.00%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.