eliaskg / Hacky

Hacky for Mac provides browsing Hacker News in a clean and minimalistic way.
http://www.hackyapp.com
GNU Lesser General Public License v2.1
366 stars 56 forks source link

Hacky crashes while parsing upvoted topic #10

Closed dvbportal closed 11 years ago

dvbportal commented 11 years ago

Today Hacky suddenly refuses to start. The crash happens when I am logged in into HN using Safari. The auth cookie seems to affect Hacky. When parsing an upvoted topic, there is no id (maybe due to the missing arrow).

Printing description of topic:
{
    comments = 156;
    "created_at" = "5 hours ago";
    score = 166;
    title = "Docker - the Linux container runtime";
    url = "http://docker.io/";
    user = radimm;
}

setReadMarks fails at

 if ([defaults valueForKey:[topic valueForKey:@"id"]]) {
      [topic setValue:[NSNumber numberWithInt:1] forKey:@"isRead"]; 
eliaskg commented 11 years ago

Thanks for your report. Unfortunately I really can't reproduce your bug.

Still, Hacky works.

Is Hacky still crashing for you on the master branch just at the moment?

dvbportal commented 11 years ago

Hi, I am on master and its still crashing. Docker is not on the front page anymore, but I can still reproduce this with any other topic. Maybe it has something to do with my account. Can you think of any case that the parser does not find the id field? All other fields are filled. Anyways, if no one has this problem you can close this issue, because I have fixed it for me.

eliaskg commented 11 years ago

On what version do you run Hacky? (Menu: Hacky -> About)

dvbportal commented 11 years ago

I am on Version 1.1 (1.1)