search

eliaskg / Hacky

Hacky for Mac provides browsing Hacker News in a clean and minimalistic way.
http://www.hackyapp.com
GNU Lesser General Public License v2.1
366 stars 56 forks source link

Relative URL's won't open #12

Closed mickn closed 11 years ago

mickn commented 11 years ago

When clicking on a relative URL (mostly 'Ask HN' topics), the URL will not open. The website which is parsed does not provide a base URL for local pages.

Hacky should check if a base URL is given and otherwise add 'http://news.ycombinator.com/'.

eliaskg commented 11 years ago

Thanks for your report! The issue is known and will be fixed in the upcoming update.

mickn commented 11 years ago

Great! I couldn't wait, so wrote a quick fix for myself. Maybe you can use it, if you haven't fixed it already. 53ec3cae0892e0d99dac1e3e0551820df6480ad0

eliaskg commented 11 years ago

It's already fixed and waiting for review in the App Store.

Soon

mickn commented 11 years ago

Are you planning to release the code of the new version on Github as well, or is this just for the App Store?

Thanks!

eliaskg commented 11 years ago

Every update will be released on GitHub as soon as it is available in the Mac App Store.

On 26.03.2013, at 13:58, Mick Niepoth notifications@github.com wrote:

Are you planning to release the code of the new version on Github as well, or is this just for the App Store?

Thanks!

— Reply to this email directly or view it on GitHub.

sjmulder commented 11 years ago

Hey @eliaskg, it’s fantastic that your willing to share your work like this. However, this policy does make it hard for people to contribute since you never know you might be doing duplicate work or will have to rework your code when the new release drops.

eliaskg commented 11 years ago

@sjmulder Good point. I think about implementing a roadmap on GitHub so you guys know what I am currently working on.

sjmulder commented 11 years ago

Thanks, that’ll help a lot!