search

eliaskg / Hacky

Hacky for Mac provides browsing Hacker News in a clean and minimalistic way.
http://www.hackyapp.com
GNU Lesser General Public License v2.1
366 stars 56 forks source link

Make comments view optional #15

Open eliaskg opened 11 years ago

eliaskg commented 11 years ago

Since Hacky started without comments I believe there are some people who would love to hide the new comments view. Therefore I would like to provide an option in the "View" menu for hiding / showing the comments. Pull requests are welcome! ;)

lardissone commented 11 years ago

+1

rickyc commented 11 years ago

Sorry about the double commit reference there. I pushed fixes for issue 14 + 15 onto the same branch and then I rebased it so that it would only reference issue 15.

eliaskg commented 11 years ago

Hi Ricky,

thanks for your work. It's going in the right direction. I tried to implement the function before and I was at the exact same point. A major problem is hiding the NSSplitView divider when hiding the comments. In my version just like in yours the divider is still visible:

If you have any ideas how to hide it the remaining work on this feature would be relatively easy.

rickyc commented 11 years ago

Ahh, gotcha. Made the change and submitted a pull request.

eliaskg commented 11 years ago

Awesome work! Your commit will be in the next update. Thanks Ricky!

rickyc commented 11 years ago

Glad to help!