search

eliasm307 / storybook-addon-deep-controls

A Storybook addon that extends @storybook/addon-controls and provides an alternative to interacting with object arguments
MIT License
36 stars 3 forks source link

Plans for 8.0.0 #8

Closed jorgercg closed 8 months ago

jorgercg commented 8 months ago

Hi there! Great work!

Are there plans to support Storybook 8.0.0?

Again, many thanks for the great work done!

eliasm307 commented 8 months ago

Hi, yes I will once storybook 8 is officially released

eliasm307 commented 8 months ago

Btw @jorgercg i tried this with the current Storybook 8 release candidate and it seemed to work without any functionality changes.

So I'll just be updating the peer dependency version range to include storybook 8.

Let me know if there is an issue you are having with storybook 8 and I can look into it before it's released next week

jorgercg commented 8 months ago

Yes! I have the same here, no problem whatsoever with 8.0.0. In fact, during the build process it shows a message that made me imply that it would not work, but in fact it does!

Thanks for your prompt response and for the awesome work done!

eliasm307 commented 8 months ago

OK cool, I've now published v0.6.1 which adds storybook 8 to the allowed peer dependency versions

I'll close this issue, but if you have any issues when using v8 please raise a separate ticket

tidemann commented 8 months ago

Just tried to set it up with 8.0.0-rc.3:

WARN The following packages are incompatible with Storybook 8.0.0-rc.3 as they depend on different major versions of Storybook packages: WARN - storybook-addon-deep-controls@0.6.1

eliasm307 commented 8 months ago

@tidemann yes I've set it to accept v8 but only the official releases, not sure if I can set it to accept release candidate versions which are not written in proper semver notation

Either way, you can ignore the warning when installing, it should still work. If it doesn't then please raise an issue

eliasm307 commented 8 months ago

When 8.0.0 is officially released you shouldn't get the install warning

jorgercg commented 8 months ago

Yes, 8.0 and the install warning is gone!!!!

Jorge Gonçalves

On Mon, Mar 11, 2024 at 3:03 PM eliasm307 @.***> wrote:

When 8.0.0 is officially released you shouldn't get the install warning

— Reply to this email directly, view it on GitHub https://github.com/eliasm307/storybook-addon-deep-controls/issues/8#issuecomment-1988654418, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFBX4MN5A32NE3ODM6RIQCDYXXBTPAVCNFSM6AAAAABEJLYCSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBYGY2TINBRHA . You are receiving this because you were mentioned.Message ID: @.***>