eliben / pss

pss is a power-tool for searching inside source code files.
Other
327 stars 46 forks source link

Add optional support for PEP278 universal newlines #36

Closed yaheath closed 8 years ago

yaheath commented 8 years ago

A new argument (-U, --universal-newlines) makes pss open files with the U flag, which makes python auto-detect the files' newlines format. Especially useful for searching MacOS files which have CR only newlines.

eliben commented 8 years ago

Thanks for the contribution!

Is it possible to create a test that will exercise this?

yaheath commented 8 years ago

Replaced the and/or with if/else and implemented tests. The tests revealed bugs under python 3.x, so those have been fixed too.

eliben commented 8 years ago

Thanks! Please squash PR into a single commit and this is good to go

eliben commented 8 years ago

Ugh, sorry for the delay. Thanks