Improve option parsing.

eliben / pss

pss is a power-tool for searching inside source code files.

Other

327 stars 46 forks source link

Improve option parsing. #39

Closed zondo closed 7 years ago

zondo commented 7 years ago

Changes:

use argparse instead of optparse
allow options in @-style option files
document @-style options in program help message
add simple unit test
remove VersionPrinted exception (no longer required)

The docs mention that pss support py2.6, but tox tests don't test it. If you accept this patch and want to keep py2.6 support, you could add 'argparse-safe' to the dependency list (which would install it only if running py2.6).

Cheers,

Glenn

eliben commented 7 years ago

Thanks for the contribution. The .travis.yml config does test Python 2.6 (e.g. https://travis-ci.org/eliben/pss/jobs/186349445)

It's a nice change and I prefer argparse myself, but I'm not sure the added value is worth dropping support for 2.6 at this point. It may be later, in a few years. One of the best features of pss is that it's completely dependency free, so I wouldn't want to introduce a dependency either.