Open mrtuborg opened 5 years ago
Dear Sir,
I want to propose my pull request, that helped to work with your library on my computer (macOS). Probably it will be useful for others.
I did not switched off any parts of your code to be able to compile it under osx and/or clang++, but just found appropriate system call for it.
I did the best I can to check if it still building in Linux. I was able to run all the tests described in README.md with gcc 8.1
Unfortunately, I see some issues while I am trying to compile tests with clang++ or gcc v8.3: Here the log: make tests log
I think it have sense to fix it in separate pull request to avoid too much work for reviewers.
Faithfully yours,
Vladimir.
Dear Sir,
I want to propose my pull request, that helped to work with your library on my computer (macOS). Probably it will be useful for others.
I did not switched off any parts of your code to be able to compile it under osx and/or clang++, but just found appropriate system call for it.
I did the best I can to check if it still building in Linux. I was able to run all the tests described in README.md with gcc 8.1
Unfortunately, I see some issues while I am trying to compile tests with clang++ or gcc v8.3: Here the log: make tests log
I think it have sense to fix it in separate pull request to avoid too much work for reviewers.
Faithfully yours,
Vladimir.