search

elibroftw / music-caster

Music Caster is a modern music player with the ability to cast audio files, system audio, and URLs to Google Chromecasts, Google Home/Nest Minis, etc.
https://elijahlopez.ca/music-caster/
Other
142 stars 16 forks source link

Hard coded UI strings on Timer tab #72

Closed fz0000 closed 3 months ago

fz0000 commented 3 months ago

I found that some UI strings are not translated. e.g.

https://github.com/elibroftw/music-caster/blob/0b9bc54d3d381d11b6c3032bd959892f7924051e/src/music_caster.py#L3285 image

and

https://github.com/elibroftw/music-caster/blob/0b9bc54d3d381d11b6c3032bd959892f7924051e/src/music_caster.py#L2785 https://github.com/elibroftw/music-caster/blob/0b9bc54d3d381d11b6c3032bd959892f7924051e/src/music_caster.py#L3275 image

By the way, it seems that the following string is not in the translation file. But I think it's acceptable: https://github.com/elibroftw/music-caster/blob/0b9bc54d3d381d11b6c3032bd959892f7924051e/src/gui/views.py#L361 image

elibroftw commented 3 months ago

As for the credits text, yeah that was done intentionally even though "by" isn't really a word in other languages.