Closed silverjam closed 4 years ago
Yeah looks good! Thanks!
@elichai How does this look? I think we've resolved all concerns from the previous PR.
@elichai How does this look? I think we've resolved all concerns from the previous PR.
Hi, Yeah it does look good, I'm currently swamped but this weekend I'll read about async blocks, test and merge this (and I hope I'll also make actual working tests that check that the log is correct)
@elichai How does this look? I think we've resolved all concerns from the previous PR.
Hi, Yeah it does look good, I'm currently swamped but this weekend I'll read about async blocks, test and merge this (and I hope I'll also make actual working tests that check that the log is correct)
Sounds great! Thank you!
There were many changes in #22, so I used your changes for Travis there.
closed in favor of #22
Added Travis support to your PR (#22) @DmitrySamoylov