search

elichai / log-derive

A procedural macro for auto logging output of functions
https://docs.rs/log-derive
Apache License 2.0
189 stars 12 forks source link

Add async support (with Travis) #24

Closed silverjam closed 4 years ago

silverjam commented 4 years ago

Added Travis support to your PR (#22) @DmitrySamoylov

DmitrySamoylov commented 4 years ago

Yeah looks good! Thanks!

silverjam commented 4 years ago

@elichai How does this look? I think we've resolved all concerns from the previous PR.

elichai commented 4 years ago

@elichai How does this look? I think we've resolved all concerns from the previous PR.

Hi, Yeah it does look good, I'm currently swamped but this weekend I'll read about async blocks, test and merge this (and I hope I'll also make actual working tests that check that the log is correct)

silverjam commented 4 years ago

@elichai How does this look? I think we've resolved all concerns from the previous PR.

Hi, Yeah it does look good, I'm currently swamped but this weekend I'll read about async blocks, test and merge this (and I hope I'll also make actual working tests that check that the log is correct)

Sounds great! Thank you!

DmitrySamoylov commented 4 years ago

There were many changes in #22, so I used your changes for Travis there.

silverjam commented 4 years ago

closed in favor of #22