elicit-experiment / frontend

Elicit experiment frontend
Creative Commons Attribution 4.0 International
0 stars 0 forks source link

ColumnWidthPercent not enforced correctly #20

Open madjens opened 1 week ago

madjens commented 1 week ago

I have tested the new layout setting and the ColumnWidthPercent doesnt seem to be used for the no stimuli case

code to reproduce tests/Testcase_likertscale.py

Example experiment https://elicit-experiment.com/studies/1130/protocols/1128

image

Setting the column width to either 30 or 80 does not have an affect. More importantly in the case of an audio stimuli, there is a large gap between the instrument and the stimuli, leaving the instrument to the far right. We want to have a a column with the same width for the whole page.

iainbryson commented 2 days ago

@madjens a question about what you want the behavior here to be:

The components are always centered right now, and so this means if we set the width at 30% it won't make a large visible difference. Do you want to always right align? e.g. image

A similar issue arises with the stimulus issue. We can shrink the column size, and this is what you'd see:

image

Is that reasonable? The other option would be to always left-align the stimulus maybe, but it would likely change a lot of things and require tweaking:

image

madjens commented 7 hours ago

I was thinking something like this where the page is divided in to 2 columns that each have a width (total size 100), which remain the same size regardless whether there is stimuli attached or not so the scales are aligned across the page. I.e. we no longer have the options AlignToStimuli

image

Within each column we want it to look uniform across the page (with or without the stimuli)

I think the HeaderLabel should be centered above the stimuli, i.e. the last image you show looks bad as the playbutton is all the way to the right compared to the text. But the position of the label compared to the instrument is good i think.

madjens commented 6 hours ago

So essentially regardless of there is an instrument in the component, the instrument is still the same size.