Guns don't work against the Ender Dragon

[cranberriez]

First noticed this on my modpack with quite a lot of other mods.

Guns do absolutely no damage to either crystals or the dragon from any range with any gun.

This also happens when the mod is played entirely on its own.

In both cases the guns were acquired and used in creative mode.

Crafting the gun in survival yields the same results.

Fabric-0.14.22 Minecraft 1.19.2

Fabric API fabric-api-0.76.0+1.19.2.jar

GeckoLib geckolib-fabric-1.19-3.1.40.jar

Simple Animated Guns (Fabric) SimpleAnimatedGuns-FR-1.19.2-v1.2.jar

[thegatesdev]

Might be an issue related to the hitboxes of the dragon. Since there are multiple hitboxes, the guns might hit the ones that don't actually record damage.

[avirtual777]

I found this too, but it is different in BETA version in BETA version the guns can kill Wither below 1/2 HP, which should be immune to RANGED damage Maybe this is a bugfix with new bugs XD

[cranberriez]

My potential fix to this issue https://github.com/elidhan/Simple-Animated-Guns/compare/1.18.2v1-test-arms-weaponmods...cranberriez:Simple-Animated-Guns:1.18.2v1-test-arms-weaponmods-1

I can't really test this but it should account for hitting the 'part' of ender dragon since it isn't considered a LivingEntity. Hopefully should apply the damage correctly.

[elidhan]

Rewrote the whole onEntityHit method, now it checks if entity.damage() returns true or false instead, then proceeds with the rest of the bullet exclusive stuff (which rn is just the invincibility frame bypass)

Tested it on the ender dragon, mobs, endermen, wither, and non-living entities and it seems to work as intended although now bullets will also destroy item frames just like regular arrows do, which can be a plus or minus for some

[cranberriez]

Dang, thanks for solving the issue so quickly! Love the mod, everything looks and works very well together.

My only suggestion is the ability to configure some things like damage or possible damage fall-off?

The revolvers are a bit overpowered at the moment.

[elidhan]

On top of cutting the old army revolver's damage in half while giving it the fastest firing speed of all the handguns to balance it out, I'm also trying to find a way to make the guns' stats be set through datapacks instead of being hardcoded (this part is gonna take a while for me though, started this last year and still trying to figure out the JSON/GSON stuff)

[king23333cao]

Rewrote the whole onEntityHit method, now it checks if entity.damage() returns true or false instead, then proceeds with the rest of the bullet exclusive stuff (which rn is just the invincibility frame bypass)

Tested it on the ender dragon, mobs, endermen, wither, and non-living entities and it seems to work as intended although now bullets will also destroy item frames just like regular arrows do, which can be a plus or minus for some

How to fix it? Can I get a mod pack with the fix? Minecraft 1.19.2