elidoran / cosmos-browserify

Browserify npm modules for client side in Meteor packages
MIT License
78 stars 12 forks source link

overwriting `stream` class inside loop #1

Closed mikowals closed 9 years ago

mikowals commented 9 years ago

Very cool package. Thanks.

I notice that at line 12 of plugin/browserify.js you assign a new value to the stream variable which is meant to hold the Stream class from NPM and is originally declared in line 2. This errors if your handler function gets called a more than once, i.e. when there is a second browserify.js source file.

elidoran commented 9 years ago

Thank you for pointing that out. I fixed it and published a new version to atmosphere.

mikowals commented 9 years ago

Thanks.