elie222 / inbox-zero

Open source email app to reach inbox zero fast.
https://getinboxzero.com
GNU Affero General Public License v3.0
2.52k stars 257 forks source link

feat: adding serverless-redis-http to docker compose #101

Closed Ipriyankrajai closed 7 months ago

Ipriyankrajai commented 8 months ago

fixes: #89

P.S. @elie222 rename the env variable UPSTASH_REDIS_URL, UPSTASH_REDIS_TOKEN to REDIS_URL, REDIS_TOKEN respectively.

vercel[bot] commented 8 months ago

@Ipriyankrajai is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

Ipriyankrajai commented 7 months ago

Hey @elie222,

I have made the changes

elie222 commented 7 months ago

Looks good! Do you mind just switching back the env var names to UPSTASH_. I like what you did. But this change will break the app for anyone using it. And I'll have to update env vars myself too.

I may make this change after incrementally but now will be best to just leave the name as is if that's okay.

Also fix the pnpm.lock conflict we have 😢 .

Ipriyankrajai commented 7 months ago

Done @elie222.