search

elie222 / inbox-zero

Open source email app to reach inbox zero fast.
https://www.getinboxzero.com
GNU Affero General Public License v3.0
2.18k stars 199 forks source link

Fix: Stats onboarding modal visiblity #118

Closed sharma-shanu closed 5 months ago

sharma-shanu commented 5 months ago

Issue :- #116

This PR fixes the issue by bumping up the version of usehooks-ts library (from 2.10.0 to 2.13.0 and above).

The utility hook "useLocalStorage" had a bug where it returned the "initialValue" passed irrespective of whether the field is available or not in the localStorage.

Hence, making it difficult to use a sentinel value in visibility logic (StatsOnboarding.tsx).

This has been patched in version 2.13.0.

vercel[bot] commented 5 months ago

@sharma-shanu is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant commented 5 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: sharma-shanu
:x: Shanu Sharma

Shanu Sharma seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

elie222 commented 5 months ago

Nice! Noticed that the modal kept popping up recently. Thanks for the fix.