search

elie222 / inbox-zero

Open source email app to reach inbox zero fast.
https://www.getinboxzero.com
GNU Affero General Public License v3.0
2.18k stars 199 forks source link

feat: adding delete button in largest item section #119

Closed ketanMehtaa closed 4 months ago

ketanMehtaa commented 5 months ago

fix #49 Please review; it has not been completed yet. not able to understand how to refetch after deletion

vercel[bot] commented 5 months ago

@ketanMehtaa is attempting to deploy a commit to the Inbox Zero Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inbox-zero ✅ Ready (Inspect) Visit Preview Feb 8, 2024 10:49pm
elie222 commented 5 months ago

fix #49 Please review; it has not been completed yet. not able to understand how to refetch after deletion

Here's how:

https://github.com/elie222/inbox-zero/pull/119/files#r1483674362

elie222 commented 4 months ago

Thanks. Made some more comments!

ketanMehtaa commented 4 months ago

Hey, mostly fine. Just move the new component into apps/web/app/(app)/stats/LargestEmails.tsx. It doesn't need a new file.

Done.

elie222 commented 4 months ago

Hey, mostly fine. Just move the new component into apps/web/app/(app)/stats/LargestEmails.tsx. It doesn't need a new file.

Done.

Nice! The final version looks pretty clean!