search

elie222 / inbox-zero

Open source email app to reach inbox zero fast.
https://www.getinboxzero.com
GNU Affero General Public License v3.0
2.18k stars 199 forks source link

Novel 2 upgrade #145

Closed elie222 closed 4 months ago

elie222 commented 4 months ago

This doesn't work right now. Opened the PR to share on Novel GitHub.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
inbox-zero ✅ Ready (Inspect) Visit Preview Feb 25, 2024 2:14am
andrewdoro commented 4 months ago

Hey you are missing the extensions config https://novel.sh/docs/guides/tailwind/setup#configure-extensions

elie222 commented 4 months ago

Hey you are missing the extensions config novel.sh/docs/guides/tailwind/setup#configure-extensions

Thanks! Probably worth noting in the quick start as many people will be using Tailwind with this package. Another dev started working on this feature and ran into the same issue btw.

We assumed the problem was that the project was still in flux rather than something we could fix.

elie222 commented 4 months ago

That wasn't the issue. This is the issue: CleanShot 2024-02-23 at 09 42 25@2x

elie222 commented 4 months ago

Also unclear to me how the most basic example should work. As the TypeScript expects a child component here: CleanShot 2024-02-23 at 09 44 34@2x

elie222 commented 4 months ago

Once setting to Bundler resolution, this is the error that appears: CleanShot 2024-02-23 at 09 54 43@2x

elie222 commented 4 months ago

Once setting to Bundler resolution, this is the error that appears: CleanShot 2024-02-23 at 09 54 43@2x

Okay. Adding extensions causes that error to go away.

I now have something to work with. I'll get the update out. Thanks for the help.

andrewdoro commented 4 months ago

Hey no problem if you have any more problems you can write me on twitter. Currently I still have to get the docs right, I am open to any feedback.

elie222 commented 4 months ago

Hey no problem if you have any more problems you can write me on twitter. Currently I still have to get the docs right, I am open to any feedback.

Will do!

Made a few more commits. This one fixed TS errors: ca51798 (#145)

Might be worth changing your example project to strict mode.

elie222 commented 4 months ago

Got it working now. Thanks for the help.

CleanShot 2024-02-23 at 10 43 43@2x

andrewdoro commented 4 months ago

Nice, keep in mind that the AI features would be changed with this PR https://github.com/steven-tey/novel/pull/297

elie222 commented 4 months ago

Nice, keep in mind that the AI features would be changed with this PR steven-tey/novel#297

Thanks. I've disabled the AI for now. I saw it didn't look right and noticed the PR.