search

elie29 / zend-di-config

PSR-11 PHP-DI container configurator for Laminas, Mezzio, ZF, Expressive applications or any framework that needs a PSR-11 container
MIT License
19 stars 4 forks source link

Php 8 Support #47

Closed NedNisW closed 3 years ago

NedNisW commented 3 years ago

I've walked through the code and tried to apply all 7.4 and 8.0 features if i was aware of them :)

One important thing about the new tempfiles folder in the tests. The Test COnfigTest::testConfigurationEnableCompilation used Vsf-FileSystem, but in a newer PHP-DI Version the code was changed to use rename for moving temp dump file to the destination. Before it was dumped directly in the target file.

Rename can handle only same system wrappers so it is not possible to rename from stream to file on disk. Therefore it needs to be adjusted in the tess.

If something is not correct with the pull request, please let me know. First time contributing ;)

NedNisW commented 3 years ago

@elie29 The spaces and anonymous function on a new line are because laminas-coding-standard has changed a lot. If i revert this, we will fail with the phpcs check. Any thoughts on this? We can use another coding standard if you're interested.