libprotobuf-mutator fails to build when using WEBGPU_BACKEND=DAWN

eliemichel / WebGPU-distribution

Distributions of WebGPU for native and web development, easy to integrate and interchangeable.

MIT License

159 stars 29 forks source link

libprotobuf-mutator fails to build when using WEBGPU_BACKEND=DAWN #20

Closed jpvanoosten closed 5 months ago

jpvanoosten commented 5 months ago

The libprotobuf-mutator library fails to build when using WEBGPU_BACKEND=DAWN since it seems to be missing the google/protobuff library dependency when compiling on Windows (Visual Studio 2022). I did not try other platforms.

This is not an issue since it doesn't seem that anything depends on libprotobuf-mutator so perhaps this target can be disabled or deleted?

eliemichel commented 5 months ago

Yes indeed, this was reported in https://github.com/eliemichel/LearnWebGPU/issues/62 as well, and for the dawn-prebuilt repo I had to change fetch_dawn_dependencies.py a little bit.

As mentioned in the issue linked above, a simple fix is to upgrade Dawn version number, I'll do this asap

eliemichel commented 5 months ago

Upgraded in WebGPU-distribution's main as well as all branches of LearnWerbGPU-Code that used that version of the distribution.

jpvanoosten commented 5 months ago

You also need to update the FetchDawn.cmake file to fetch the chromium/6536 tag please ;) Add add the following targets to the AllDawnTargets list:

tint_lang_core_common
tint_lang_hlsl_writer_printer
tint_lang_hlsl_writer_raise

Thanks in advance!

eliemichel commented 5 months ago

Woops, what did I do, thanks!

jpvanoosten commented 5 months ago

Great, Thanks! I have another quality of life improvement for you! See #21 😄