Closed jpvanoosten closed 3 months ago
Thanks, looks good to me! :)
Don't forget to update the corresponding GIT_TAG
hash in the main branch ;)
Don't forget to update the corresponding
GIT_TAG
hash in the main branch ;)
PR #30 fixes this.
@jpvanoosten What was your use case for this? I realize this actually has Dawn default values be used instead of our values. Unless we force cache values, but would that defeat your use case? I believe Dawn creates these cache variables even if we do not declare them as cache variables here, only it used to use our value as the default.
Regression that is likely due to this change: Dawn build now tries to use DirectX on Windows by default, which is supposed to be turned off.
This commit prevents cache variables from being hidden in the CMake GUI. Also, if specific backends are enabled, force the appropriate writers to be built to prevent compiler & linker errors (this really should be done in the Dawn library, but it's not!).