search

elieserdejesus / JamTaba

Jamtaba is a software to play online music jam sessions.
http://www.jamtaba.com
244 stars 50 forks source link

VST plugin doesn't report window size without editor being opened #1231

Open Spacechild1 opened 4 years ago

Spacechild1 commented 4 years ago

A user of my VST plugin host (https://github.com/Spacechild1/vstplugin) reported that the plugin editor window had a width and height of 0. It turns out in your plugin a call to effEditGetRect before effEditOpen returns false and sets the output values to 0. Only very few plugins do this (in fact, I've only encountered 1-2 or so). I fixed my VST host to handle this case, but you might consider to alway report the editor size, like the vast majority of VST plugins do.

I couldn't really try your plugin so far, but from what I saw it looks great!

elieserdejesus commented 4 years ago

thanks for point out the problem @Spacechild1 .

The JamTaba window (using Qt) is created inside effEditOpen, so the editor window size is not available before the call to effEditOpen. Not shure how to solve yet, but I will put this in the list for the next version.

Spacechild1 commented 4 years ago

It's not a big deal. After all, most VST hosts can deal with this situation.

Not shure how to solve yet,

Most plugins know the size of the editor beforehand. If this is not possible, the plugin would use the audioMasterSizeWindow opcode to tell the host the size of the window after opening the editor.

elieserdejesus commented 4 years ago

thanks @Spacechild1 , I will check this soon.