search

elieserdejesus / JamTaba

Jamtaba is a software to play online music jam sessions.
http://www.jamtaba.com
244 stars 49 forks source link

Voice chat dropping all audio before next bpi cycle starts #1250

Open jonjamcam opened 4 years ago

jonjamcam commented 4 years ago

testing further the voice chat feature I found that:

1.- voice chat does not start as soon as I press the button. It waits until the next bpi cycle starts.

2.- all audio sent before the actual starting mentioned before is discarded.

So one problem I think could be for long bpi (i.e. 64) you have to wait a long time to actually use the feature. Of course if you use two channels and voice chat is active in one channel all the time this is no problem.

3.- Voice chat is working when video is used, but the video feed looks it's working in ninjam mode, so for consistency there are two options:

1.- make video work as voice chat when button pressed in channel 1

or

2.- hide/disable voice chat button when using video and force channel 1 to be in ninjam mode.

NOTE: to confirm these observations I need to test in a real jamming situation. ALL tests were made using video channel enabled.

jonjamcam commented 4 years ago

Tested in real world. While using video and voice chat Trashcanhead commented that audio and video were in sync. I don't know if this was by chance or was indeed coded on purpose. I don't know either if the audio was actually being received as voice chat or it was in normal mode (as explained earlier for first two bpi cycles)

elieserdejesus commented 4 years ago

I don't know if this was by chance or was indeed coded on purpose.

by chance, ninjam it`s not possible ensure 2 streams are in sync, but using good internet connections the chances to be in sync are high.