search

elieserdejesus / JamTaba

Jamtaba is a software to play online music jam sessions.
http://www.jamtaba.com
245 stars 49 forks source link

A new Korean translation TS file added #1307

Closed soulraymusic closed 4 years ago

soulraymusic commented 4 years ago

This is the Korean translation version 1.0.

elieserdejesus commented 4 years ago

Hi @soulraymusic , I can't merge your file directly becayse github is pointing a lot of conflicts.

I can download your file, replace the old one and just commit and push, but your name will not be listed as a contributor (bad).

So, can you try solve this conflict in your side and create a new pull request?

soulraymusic commented 4 years ago

Hi @soulraymusic , I can't merge your file directly becayse github is pointing a lot of conflicts.

I can download your file, replace the old one and just commit and push, but your name will not be listed as a contributor (bad).

So, can you try solve this conflict in your side and create a new pull request?

Yes, I will try it now!

soulraymusic commented 4 years ago

@elieserdejesus conflicts resolved. What is the next step?

elieserdejesus commented 4 years ago

@elieserdejesus conflicts resolved. What is the next step?

Thanks @soulraymusic , I will merge your translation and generate the other files. Your contribution is done!!!! Thanks again!

elieserdejesus commented 4 years ago

@soulraymusic , The Korean translation menu entry is showing (C). Is it ok? image

elieserdejesus commented 4 years ago

@soulraymusic , problem is solved. The correct name of Korean translation file is ko_KR.ts. The old file was kr_KR.ts, not a valid locale.

It's fixed now: image