elieserdejesus / JamTaba

Jamtaba is a software to play online music jam sessions.
http://www.jamtaba.com
245 stars 49 forks source link

fixing crash when user = bot name 'booga' #1334

Closed jonjamcam closed 4 years ago

jonjamcam commented 4 years ago

Jamtaba is crashing when user inside room is named as bot 'booga'.

elieserdejesus commented 4 years ago

@jonjamcam , let me investigate why this name is crashing. I suspect this is a more general problem and other names will crash in future too. Is better solve the problem in the "root". I will check this issue soon.

elieserdejesus commented 4 years ago

@jonjamcam , I tested here in local server and can't reproduce the bug.

I just connected in my local server using 'booga' as username (in ReaNinjam) and connected in the server using JamTAba. No crash!

The problem is only when theres a boot named 'booga' and an user with same name, right?

Any ideas to reproduce the bug?

jonjamcam commented 4 years ago

The problem is only when theres a boot named 'booga' and an user with same name, right?

Yes. It happened to me some days ago. Server was ninjam.live:2049 I think. The user was from US.

I tried to enter several times, the crash happened when the first bpi interval of 120/16 ends so you need to wait some seconds while inside the server.

Edit : new issue created https://github.com/elieserdejesus/JamTaba/issues/1337