search

elieserdejesus / JamTaba

Jamtaba is a software to play online music jam sessions.
http://www.jamtaba.com
245 stars 49 forks source link

Allow higher bitrates on private servers #1348

Open davr opened 4 years ago

davr commented 4 years ago

Hello, I would like to be able to set a higher bitrate than 128kbit when using a private server where I control both the server and clients, so you don't have to worry about using too much data on public servers.

Really all I'm asking is to remove this line that caps the bitrate: https://github.com/elieserdejesus/JamTaba/blob/master/src/Common/persistence/Settings.cpp#L269

I'm interested in using this with a limited number of clients (3 clients, 2 of them transmitting) to do live mixing between two djs, where a single channel will be an entire song, not just one instrument, and the final mix will be re-encoded to a live broadcast.

elieserdejesus commented 4 years ago

Hi @davr , is not too simple. If I remote the line you mentioned everybody can change the bit rate for a huge value and use this very high bitrate in public servers.

The idea of allow higher bitrates in private servers make sense, but we need think in a more robust solution. Just remove the mentioned line is not enough.

davr commented 4 years ago

Maybe the servers themselves should limit bitrate? They could change their server code to drop anyone who goes over a certain bitrate, maybe send them a message too. Or even do things like allowing higher bitrate for people who donate, etc

jonjamcam commented 4 years ago

Maybe the servers themselves should limit bitrate? They could change their server code to drop anyone who goes over a certain bitrate, maybe send them a message too.

Hi @davr . Over the years many of us have proposed several improvements, lots of great ideas that ultimately crash due to some year old server code that will most likely not going to be updated anytime soon. And because Ninjam clients and servers talk to each other in an "ecosystem" we always set the bar to the lowest common denominator.

Fortunately Jamtaba is opensource, so the use you need in this particular case is possible. You just need to compile the client locally and use it as you wish, but with freedom also comes responsibility. If for any reason a client with this kind of super quality stream starts to circulate massively it could disrupt the delicate balance here. Remember that public servers use high upload bandwidth that someone is paying for (i.e. ninbot, ninjamer, etc.) and if costs start to get too high, they will just stop working.

Ogg quality is not as mp3 with regards to bitrate, so don't think 128 kbps is bad quality. If you follow this thread https://github.com/elieserdejesus/JamTaba/issues/456 you'll see we spent quite some time to try to keep the best balance between quality and bandwidth use. There's many options on the net of other software that will achieve the results you want. I would recommend you explore them first. We are a small community here with very limited resources. Hopefully you understand.