search

elieserdejesus / JamTaba

Jamtaba is a software to play online music jam sessions.
http://www.jamtaba.com
245 stars 49 forks source link

update public view hack for correct room capacity #1409

Closed jonjamcam closed 2 years ago

zenjam commented 2 years ago

I just spent some time fixing the live serverlist.... user_max - now correct user_count - added and is from the live servers so includes bots

zenjam commented 2 years ago

Okay correcting the user_max caused jamtaba to have the wrong number So ive added user_limit to show the correct number for max users and added one for user_max jamataba

Summary please feel free to user "user_limit" for future versions and user_max will be left for older jamtaba versions.

-Tom

jonjamcam commented 2 years ago

Hi Tom, Elieser. I find the updated user_max value is showing +1 value compared to cockos list. But it's foing to get obsolete as soon as the new version is released.

Just tested the new 'user_limit' entry. This value is the correct one for most servers, except for ninbot and ninjamer (considering yesterday's commit using the updated hack).

For this reason if Tom is using existing official releases to address this issue, the value will always be +1 for ninbot and ninjamer servers.

Happy to work on this if needed.

cheers

On Sun, Oct 31, 2021, 17:39 Zenjam @.***> wrote:

Okay correcting the user_max caused jamtaba to have the wrong number So ive added user_limit to show the correct number for max users and added one for user_max jamataba

Summary please feel free to user "user_limit" for future versions and user_max will be left for older jamtaba versions.

-Tom

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elieserdejesus/JamTaba/pull/1409#issuecomment-955787729, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUZ4YK5YFYQBOQ3OGOB753UJWSOJANCNFSM5HBQKXPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

zenjam commented 2 years ago

I think the confusion is that the bot names are removed from the users list so they wouldnt show up in serverlist

We need to sort this out maybe user_count includes the bot user_limit is how many can join including the bot user_max is user_limit - 1 (to correct for current jamtaba)

On Sun, Oct 31, 2021 at 3:52 PM jonjamcam @.***> wrote:

Hi Tom, Elieser. I find the updated user_max value is showing +1 value compared to cockos list. But it's foing to get obsolete as soon as the new version is released.

Just tested the new 'user_limit' entry. This value is the correct one for most servers, except for ninbot and ninjamer (considering yesterday's commit using the updated hack).

For this reason if Tom is using existing official releases to address this issue, the value will always be +1 for ninbot and ninjamer servers.

Happy to work on this if needed.

cheers

On Sun, Oct 31, 2021, 17:39 Zenjam @.***> wrote:

Okay correcting the user_max caused jamtaba to have the wrong number So ive added user_limit to show the correct number for max users and added one for user_max jamataba

Summary please feel free to user "user_limit" for future versions and user_max will be left for older jamtaba versions.

-Tom

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/elieserdejesus/JamTaba/pull/1409#issuecomment-955787729 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ADUZ4YK5YFYQBOQ3OGOB753UJWSOJANCNFSM5HBQKXPQ

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/elieserdejesus/JamTaba/pull/1409#issuecomment-955806058, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABQG42NW7YMJNGXIKGY54HTUJXCBTANCNFSM5HBQKXPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jonjamcam commented 2 years ago

I think that's the issue too

On Sun, Oct 31, 2021, 23:52 Zenjam @.***> wrote:

I think the confusion is that the bot names are removed from the users list so they wouldnt show up in serverlist

We need to sort this out maybe user_count includes the bot user_limit is how many can join including the bot user_max is user_limit - 1 (to correct for current jamtaba)

On Sun, Oct 31, 2021 at 3:52 PM jonjamcam @.***> wrote:

Hi Tom, Elieser. I find the updated user_max value is showing +1 value compared to cockos list. But it's foing to get obsolete as soon as the new version is released.

Just tested the new 'user_limit' entry. This value is the correct one for most servers, except for ninbot and ninjamer (considering yesterday's commit using the updated hack).

For this reason if Tom is using existing official releases to address this issue, the value will always be +1 for ninbot and ninjamer servers.

Happy to work on this if needed.

cheers

On Sun, Oct 31, 2021, 17:39 Zenjam @.***> wrote:

Okay correcting the user_max caused jamtaba to have the wrong number So ive added user_limit to show the correct number for max users and added one for user_max jamataba

Summary please feel free to user "user_limit" for future versions and user_max will be left for older jamtaba versions.

-Tom

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/elieserdejesus/JamTaba/pull/1409#issuecomment-955787729

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ADUZ4YK5YFYQBOQ3OGOB753UJWSOJANCNFSM5HBQKXPQ

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/elieserdejesus/JamTaba/pull/1409#issuecomment-955806058 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABQG42NW7YMJNGXIKGY54HTUJXCBTANCNFSM5HBQKXPQ

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/elieserdejesus/JamTaba/pull/1409#issuecomment-955881103, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADUZ4YOFHCWSDDUIQAZFUQDUJX6FRANCNFSM5HBQKXPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.