Remove @pub-type attributes from XML (depreciated tag in JATS)

Melissa37 commented 5 years ago

Problem / Motivation

WHO; Production
WHEN: When all other updates are made
WHERE: In the XML
WHAT: change @pub-type to @date-type in the XML pub-date pub-type="collection"> to pub-date date-type="collection">
WHY: @pub-type is depreciated in favour of @date-type and @publication-format. This will also match Texture requirements.

Proposed solution

change @pub-type to @date-type in the XML pub-date pub-type="collection"> to pub-date date-type="collection">

Clarification needed and assumptions

Tasks

[ ] Check in PMC style checker
[ ] Check does not affect any Bot processes

Technical notes

@gnott

User interface / Wireframes

gnott commented 5 years ago

In the JATS parser we can support both, I'm tempted to do that now so it doesn't creep up on us.

We still use the "collection" date to determine from the XML alone whether it is a PoA or non-PoA article version in some places, the PubMed delivery logic I think.

Melissa37 commented 5 years ago

That's good. Thanks!

gnott commented 5 years ago

Is this completed now @Melissa37 ?

Melissa37 commented 5 years ago

No, it's on the long list for Texture implementation.

elifesciences / XML-mapping